Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "all" configuration that includes all rules #298

Closed
emlai opened this issue Feb 19, 2019 · 4 comments · Fixed by #313
Closed

Add "all" configuration that includes all rules #298

emlai opened this issue Feb 19, 2019 · 4 comments · Fixed by #313
Labels
enhancement New feature or request good first issue Good for newcomers has pr there is a PR raised to close this package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@emlai
Copy link

emlai commented Feb 19, 2019

For example, eslint has eslint:all, eslint-plugin-react has plugin:react/all.

I propose to add a similar option to typescript-eslint.

@emlai emlai added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Feb 19, 2019
@bradzacher bradzacher added enhancement New feature or request good first issue Good for newcomers and removed triage Waiting for maintainers to take a look labels Feb 19, 2019
@ldrick
Copy link
Contributor

ldrick commented Feb 23, 2019

Hi, I did some work on this and have three questions left, before opening the PR.

  1. What would you expect in all.json, error or warn for rules, which have meta.docs.recommended === false?
  2. Would you expect for rules known to rival with eslint (like indent)? Disable eslint rules, like recommended.json?
  3. Shall this be used as baseConfig for all.json, like in recommended.json?
const baseConfig = {
  parser: '@typescript-eslint/parser',
  parserOptions: {
    sourceType: 'module',
  },
  plugins: ['@typescript-eslint'],
};

@emlai
Copy link
Author

emlai commented Feb 24, 2019

  1. What would you expect in all.json, error or warn for rules, which have meta.docs.recommended === false?

I would probably prefer error because I don't use warn.

  1. Would you expect for rules known to rival with eslint (like indent)? Disable eslint rules, like recommended.json?

Yes I think disabling the eslint rules would be best because I will probably do that anyway when I notice that the eslint rule doesn't work with typescript.

  1. Shall this be used as baseConfig for all.json, like in recommended.json?

Probably yes, for consistency.

@ldrick
Copy link
Contributor

ldrick commented Feb 25, 2019

@emlai Thanks for your feedback, I did 2. and 3. like you said and just thought on having 1. defaulting to warn just, because if the rule isn't recommended, it might be not an error, which this rule covers.

@VincentLanglet
Copy link

@ldrick see #313 (comment)

All rules should be set as error in the all config.

@bradzacher bradzacher added the has pr there is a PR raised to close this label Apr 25, 2019
@ldrick ldrick mentioned this issue May 13, 2019
14 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers has pr there is a PR raised to close this package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants