Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-var-requires] Invalid version number identifier in context link #3480

Closed
2 of 3 tasks
oliversalzburg opened this issue Jun 3, 2021 · 3 comments
Closed
2 of 3 tasks
Labels
duplicate This issue or pull request already exists package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@oliversalzburg
Copy link

In a TypeScript project, I have this line in a file:

const path = require("path");

require("path") will have red squiggly lines under it. If I hover over the element, I get a popover describing the issue as:

Require statement not part of import statement.eslint@typescript-eslint/no-var-requires

The last part of which is a link that, when clicked, leads to an invalid URL:

https://github.com/typescript-eslint/typescript-eslint/blob/v%5Bobject%20Object%5D/packages/eslint-plugin/docs/rules/no-var-requires.md

image

Previously reported as microsoft/vscode-eslint#1274

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have read the FAQ and my problem is not listed.

Repro

https://github.com/oliversalzburg/vscode-eslint-version-repro

Expected Result

The link is valid.

Actual Result

It is not.

Additional Info

Versions

See the version information in the reproduction.

package version
@typescript-eslint/eslint-plugin X.Y.Z
@typescript-eslint/parser X.Y.Z
TypeScript X.Y.Z
ESLint X.Y.Z
node X.Y.Z
@oliversalzburg oliversalzburg added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Jun 3, 2021
@KuryKat
Copy link

KuryKat commented Jun 3, 2021

I was going to make a new issue to report the same error and I saw your issue, I confirm this bug, and it's not just for this "no-var-requires" rule, it's for all rules.

image

image

I've changed the "v[object Object]" to "master" when I need to read the documentation, but they should fix it soon, considering that not everyone knows, or has the patience, to switch to "master" in the link (and because it's more feasible that the system works as it should, by pointing to the valid URL)

@bradzacher
Copy link
Member

Duplicate of #3473

Please use the search next time

@bradzacher bradzacher added duplicate This issue or pull request already exists and removed triage Waiting for maintainers to take a look labels Jun 3, 2021
@oliversalzburg
Copy link
Author

How nice of you to assume I didn't use the search 😉

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

No branches or pull requests

3 participants