Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ban-ts-ignore is not in "plugin:@typescript-eslint/recommended" despite the docs saying so. #353

Closed
dashmug opened this issue Mar 15, 2019 · 2 comments · Fixed by #313
Closed

ban-ts-ignore is not in "plugin:@typescript-eslint/recommended" despite the docs saying so. #353

dashmug opened this issue Mar 15, 2019 · 2 comments · Fixed by #313
Labels
bug Something isn't working documentation Documentation ("docs") that needs adding/updating has pr there is a PR raised to close this package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@dashmug
Copy link

dashmug commented Mar 15, 2019 •
edited

It should be recommended according to https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin#supported-rules. But simply extending plugin:@typescript-eslint/recommended does not enable the rule.

Adding the rule explicitly in eslintrc.js works though.

Repro

Repro to follow.

Expected Result

Actual Result

Additional Info

Versions

package version
@typescript-eslint/eslint-plugin 1.4.2
@typescript-eslint/parser 1.4.2
TypeScript 3.3.3333 😄
ESLint 5.15.1
node 11.11.0
yarn 1.13.0
@dashmug dashmug added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Mar 15, 2019
@bradzacher
Copy link
Member

we really need to add a build step to validate the recommended generation.
there's a number

@bradzacher bradzacher added bug Something isn't working and removed triage Waiting for maintainers to take a look labels Mar 15, 2019
@bradzacher bradzacher mentioned this issue Mar 15, 2019
Closed
@ldrick
Copy link
Contributor

ldrick commented Mar 15, 2019 •
edited

Thats kinda related to my PR #313
There we agreed on removing the recommended for new rules, until next Major release.

@bradzacher I should update the docs for the rules I removed recommended, too?

@ldrick ldrick mentioned this issue Mar 20, 2019
Merged
@bradzacher bradzacher added documentation Documentation ("docs") that needs adding/updating has pr there is a PR raised to close this labels Apr 19, 2019
@typescript-eslint typescript-eslint locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working documentation Documentation ("docs") that needs adding/updating has pr there is a PR raised to close this package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
3 participants
@dashmug @ldrick @bradzacher