Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): remove object from ban-types' default types #3818

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Aug 29, 2021

BREAKING CHANGE: ban-types no longer reports object by default


Part of #3738
Part of #3746

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added breaking change This change will require a new major version to be released enhancement: plugin rule option New rule option for an existing eslint-plugin rule labels Aug 30, 2021
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also in the rule docs - could you please remove it from there too? thanks!

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Aug 30, 2021
BREAKING CHANGE: `ban-types` no longer reports `object` by default
@MichaelDeBoey MichaelDeBoey force-pushed the update-ban-types-default-options branch from ee38e47 to 9c30ed0 Compare August 30, 2021 08:10
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #3818 (9c30ed0) into v5 (68daff9) will increase coverage by 0.87%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##               v5    #3818      +/-   ##
==========================================
+ Coverage   92.58%   93.46%   +0.87%     
==========================================
  Files         324      147     -177     
  Lines       11276     7819    -3457     
  Branches     3185     2476     -709     
==========================================
- Hits        10440     7308    -3132     
+ Misses        383      175     -208     
+ Partials      453      336     -117     
Flag Coverage Δ
unittest 93.46% <ø> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/ban-types.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/esnext.full.ts
...e-manager/src/scope/FunctionExpressionNameScope.ts
packages/scope-manager/src/scope/GlobalScope.ts
...s/experimental-utils/src/eslint-utils/deepMerge.ts
...ges/scope-manager/src/definition/DefinitionBase.ts
...s/scope-manager/src/lib/es2020.symbol.wellknown.ts
...l-utils/src/ast-utils/eslint-utils/astUtilities.ts
packages/scope-manager/src/scope/TypeScope.ts
...utils/src/ast-utils/eslint-utils/PatternMatcher.ts
... and 168 more

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Aug 30, 2021
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@bradzacher bradzacher added this to the 5.0.0 milestone Aug 30, 2021
@bradzacher bradzacher merged commit faf2d1d into typescript-eslint:v5 Aug 30, 2021
@MichaelDeBoey MichaelDeBoey deleted the update-ban-types-default-options branch August 30, 2021 18:26
bradzacher pushed a commit that referenced this pull request Sep 3, 2021
…3818)

BREAKING CHANGE: `ban-types` no longer reports `object` by default
bradzacher pushed a commit that referenced this pull request Sep 21, 2021
…3818)

BREAKING CHANGE: `ban-types` no longer reports `object` by default
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change will require a new major version to be released enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants