New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): remove object
from ban-types
' default types
#3818
feat(eslint-plugin): remove object
from ban-types
' default types
#3818
Conversation
Thanks for the PR, @MichaelDeBoey! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is also in the rule docs - could you please remove it from there too? thanks!
BREAKING CHANGE: `ban-types` no longer reports `object` by default
ee38e47
to
9c30ed0
Compare
Codecov Report
@@ Coverage Diff @@
## v5 #3818 +/- ##
==========================================
+ Coverage 92.58% 93.46% +0.87%
==========================================
Files 324 147 -177
Lines 11276 7819 -3457
Branches 3185 2476 -709
==========================================
- Hits 10440 7308 -3132
+ Misses 383 175 -208
+ Partials 453 336 -117
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this!
…3818) BREAKING CHANGE: `ban-types` no longer reports `object` by default
…3818) BREAKING CHANGE: `ban-types` no longer reports `object` by default
BREAKING CHANGE:
ban-types
no longer reportsobject
by defaultPart of #3738
Part of #3746