Getting warnings even with allowTypedFunctionExpressions set to true

[saranshkataria]

After adding the
rules: { allowTypedFunctionExpressions: true }
for the alpha release (#149), I still see them as warnings

Repro

Code repo: https://github.com/saranshkataria/frontend-starter-kit

{
  rules: {
    allowTypedFunctionExpressions: true,
  }
}

import React from 'react';
import { hot } from 'react-hot-loader/root';

const App: React.FunctionComponent<{}> = () => <div>Hello World</div>;
App.displayName = 'App';
export default hot(App);

Expected Result
No warnings

Actual Result
Get warnings

Additional Info

Versions

package	version
@typescript-eslint/eslint-plugin	1.5.1-alpha.5
@typescript-eslint/parser	1.5.1-alpha.5
TypeScript	3.3.4000
ESLint	5.15.3
node	8.15.0
npm	6.4.1

[bradzacher]

In this instance, you have eslint misconfigured.
The correct syntax for configuring rules is:

{
  "rules": {
    "<rule_name>": ["<level>", <options>],
  }
}

I.e. for @typescript-eslint/explicit-function-return-type:

{
  "rules": {
    "@typescript-eslint/explicit-function-return-type": ["error", {
      "allowTypedFunctionExpressions": true
    }],
  }
}

[saranshkataria]

Thanks!

[saranshkataria]

@bradzacher I made the changes and it works for tsx files, but when I run lint, it fails on test files. Since I already have the types included, it shouldn't?

[bradzacher]

https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/explicit-function-return-type.md#allowexpressions

[saranshkataria]

I have that enabled as well, but I still see an error

[saranshkataria]

I put in core-js3 in my babel config and the issue got resolved. Not sure why though.

[ben-xD]

Should @typescript-eslint not default to enabling allowTypedFunctionExpressions. Seems like everyone would face this issue otherwise? Am i overlooking something?

[bradzacher]

It's going to be the default in v2. There is a PR waiting to be merged (the last one before the v2 release)