Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): Fix allowExpressions false positives in explicit-function-return-type and incorrect documentation #388

Merged
merged 2 commits into from Mar 28, 2019
Merged

fix(eslint-plugin): Fix allowExpressions false positives in explicit-function-return-type and incorrect documentation #388

merged 2 commits into from Mar 28, 2019

Conversation

gilbsgilbs
Copy link
Contributor

Fixes #387

Also add documentation for the allowTypedFunctionExpressions which I forgot in my previous PR on this rule.

@codecov
Copy link

codecov bot commented Mar 28, 2019 •
edited

Codecov Report

Merging #388 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master    #388   +/-   ##
======================================
  Coverage    97.2%   97.2%           
======================================
  Files          68      68           
  Lines        2507    2507           
  Branches      388     388           
======================================
  Hits         2437    2437           
  Misses         44      44           
  Partials       26      26
Impacted Files Coverage Δ
...-plugin/src/rules/explicit-function-return-type.ts 100% <100%> (ø) ⬆️

@gilbsgilbs gilbsgilbs changed the title [explicit-function-return-type] Fix allowExpressions false positives and incorrect documentation fix(eslint-plugin): Fix allowExpressions false positives in explicit-function-return-type and incorrect documentation Mar 28, 2019
@bradzacher bradzacher merged commit f29d1c9 into typescript-eslint:master Mar 28, 2019
@gilbsgilbs gilbsgilbs deleted the fix-explicit-function-return-type-allow-expressions branch March 28, 2019 20:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[explicit-function-return-type] allowExpressions false positives and incorrect documentation
2 participants
@gilbsgilbs @bradzacher