Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PR template that asks for an attached issue #4010

Closed
JoshuaKGoldberg opened this issue Oct 14, 2021 · 2 comments · Fixed by #4019, #4071, #4511 or #4797
Closed

Add PR template that asks for an attached issue #4010

JoshuaKGoldberg opened this issue Oct 14, 2021 · 2 comments · Fixed by #4019, #4071, #4511 or #4797
Assignees
@JoshuaKGoldberg
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Oct 14, 2021 •
edited

As mentioned by @rafaelss95 in #3996 (comment), the PR template right now doesn't ask for an attached issue. It is no surprise then that quite a few PRs today don't have an attached issue.

I propose we switch to a template like this one with a checklist for having an attached issue that was marked as accepting PRs: https://github.com/typescript-eslint/tslint-to-eslint-config/blob/9f32f5a/.github/PULL_REQUEST_TEMPLATE.md

Current template for reference: https://github.com/typescript-eslint/typescript-eslint/blob/a4f95d3/.github/PULL_REQUEST_TEMPLATE/standard.md

(ironically skipping the issue template for this as it is docs, not code)
@JoshuaKGoldberg JoshuaKGoldberg added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Oct 14, 2021
This was referenced Oct 14, 2021
Merged
Merged
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 30, 2021
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2021
@JoshuaKGoldberg
Copy link
Member Author

Re-opening after a re-read of the template because it doesn't 100% explicitly require all checklist items be met. Wording is hard.

@JoshuaKGoldberg JoshuaKGoldberg added the accepting prs Go ahead, send a pull request that resolves this issue label Feb 3, 2022
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Feb 3, 2022
@JoshuaKGoldberg
Copy link
Member Author

Re-opening following #4795 as the template doesn't explicitly ask for an open issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
1 participant
@JoshuaKGoldberg