Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove eslint-scope types from utils #4041

Closed
bradzacher opened this issue Oct 23, 2021 · 1 comment · Fixed by #5256
Closed

Remove eslint-scope types from utils #4041

bradzacher opened this issue Oct 23, 2021 · 1 comment · Fixed by #5256
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released dependencies Issue about dependencies of the package package: utils Issues related to the @typescript-eslint/utils package
Milestone
6.0.0

Comments

@bradzacher
Copy link
Member

bradzacher commented Oct 23, 2021 •
edited by JoshuaKGoldberg

In v6, eslint-scope (like eslint in v8) started using package.json exports. This means that they no longer expose their internals.

As such - we should remove the types from utils/src/ts-eslint-scope.
@bradzacher bradzacher added breaking change This change will require a new major version to be released dependencies Issue about dependencies of the package package: utils Issues related to the @typescript-eslint/utils package labels Oct 23, 2021
@bradzacher bradzacher added this to the 6.0.0 milestone Oct 23, 2021
@JoshuaKGoldberg JoshuaKGoldberg added the accepting prs Go ahead, send a pull request that resolves this issue label Oct 25, 2021
@bradzacher bradzacher mentioned this issue May 12, 2022
Closed
@JoshuaKGoldberg JoshuaKGoldberg changed the title Remove eslint-scope types from experimental-utils Remove eslint-scope types from utils Jun 26, 2022
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jun 26, 2022
Merged
3 tasks
@JoshuaKGoldberg
Copy link
Member

#5256 is merged into #5886; closing this issue now accordingly. It'll be released as a part of the v6 major release.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released dependencies Issue about dependencies of the package package: utils Issues related to the @typescript-eslint/utils package
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

feat(utils): remove (ts-)eslint-scope types JoshuaKGoldberg/typescript-eslint
2 participants
@JoshuaKGoldberg @bradzacher