Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [no-implied-eval] ignore locally declared functions #4049

Merged
merged 4 commits into from Nov 11, 2021
Merged

fix(eslint-plugin): [no-implied-eval] ignore locally declared functions #4049

merged 4 commits into from Nov 11, 2021

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Skips giving a warning for an EVAL_LIKE_METHODS hit variable if it's redeclared as per the scope manager.

I've never used the scope analyzer before, is this the right way to do it? (is there no O(1) lookup for variables by name?)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(eslint-plugin): ignore redeclared variables fix(eslint-plugin): ignore redeclared variables in no-implied-eval Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021 •
edited

Codecov Report

Merging #4049 (24386cc) into master (81b25c1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4049   +/-   ##
=======================================
  Coverage   93.35%   93.35%           
=======================================
  Files         152      152           
  Lines        8031     8035    +4     
  Branches     2577     2579    +2     
=======================================
+ Hits         7497     7501    +4     
  Misses        180      180           
  Partials      354      354
Flag Coverage Δ
unittest 93.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/no-implied-eval.ts 94.11% <100.00%> (+0.36%) ⬆️

@nx-cloud
Copy link

nx-cloud bot commented Oct 25, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit 24386cc. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 16.x - nx test @typescript-eslint/parser

Sent with 💌 from NxCloud.

@nx-cloud
Copy link

nx-cloud bot commented Oct 25, 2021

Nx Cloud Report

CI ran the following commands for commit 911e542. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 16.x - nx test @typescript-eslint/parser
#000000 Node 16.x - nx test @typescript-eslint/experimental-utils
#000000 Node 16.x - nx test @typescript-eslint/scope-manager
#000000 Node 16.x - nx test @typescript-eslint/visitor-keys
#000000 Node 16.x - nx test @typescript-eslint/typescript-estree
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 16.x - nx run-many --target=build --all --parallel
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/typescript-estree

Sent with 💌 from NxCloud.

@bradzacher bradzacher added the bug Something isn't working label Nov 1, 2021
@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Nov 1, 2021
@netlify
Copy link

netlify bot commented Nov 11, 2021 •
edited

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 24386cc

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/618d43b27267230007e06a3a

😎 Browse the preview: https://deploy-preview-4049--typescript-eslint.netlify.app

@JoshuaKGoldberg JoshuaKGoldberg removed the awaiting response Issues waiting for a reply from the OP or another party label Nov 11, 2021
bradzacher
bradzacher approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this!

@bradzacher bradzacher changed the title fix(eslint-plugin): ignore redeclared variables in no-implied-eval fix(eslint-plugin): [no-implied-eval] ignore locally declared functions Nov 11, 2021
@bradzacher bradzacher merged commit d97140e into typescript-eslint:master Nov 11, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the no-implied-eval-scope branch November 11, 2021 17:45
This was referenced Nov 16, 2021
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 23, 2021
Open
Open
Open
Open
This was referenced Nov 27, 2021
Open
Open
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-implied-eval] False positive when using setTimeout from timers/promises
2 participants
@JoshuaKGoldberg @bradzacher