fix(eslint-plugin): [explicit-member-accessibility] private fields cannot have accessibility modifiers

[danny-may]

PR Checklist

• Addresses an existing issue: fixes [explicit-member-accessibility] False positive when using private fields #1666
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Private fields, like methods, cannot have accessibility modifiers, and so they shouldnt be required by this rule. To fix this I took the fix that was already done for private methods (#3808) and applied it to private fields too.

[typescript-eslint]

Thanks for the PR, @danny-may!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[netlify]

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: ab9a7d8

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/618bfc35a93c6700086c8c07

😎 Browse the preview: https://deploy-preview-4117--typescript-eslint.netlify.app

[nx-cloud]

Nx Cloud Report

CI ran the following commands for commit ab9a7d8. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
	Node 16.x - nx test @typescript-eslint/eslint-plugin
	Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
	Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
	Node 12.x - nx test @typescript-eslint/eslint-plugin
	Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
	Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
	Node 14.x - nx test @typescript-eslint/eslint-plugin
	Node 12.x - nx test @typescript-eslint/eslint-plugin
	Node 12.x - nx run-many --target=typecheck --all --parallel
	Node 16.x - nx test @typescript-eslint/parser
	Node 16.x - nx test @typescript-eslint/experimental-utils
	Node 16.x - nx test @typescript-eslint/scope-manager
	Node 16.x - nx test @typescript-eslint/visitor-keys
	Node 12.x - nx test @typescript-eslint/parser
	Node 16.x - nx test @typescript-eslint/typescript-estree
	Node 12.x - nx test @typescript-eslint/experimental-utils
	Node 12.x - nx test @typescript-eslint/scope-manager
	Node 16.x - nx run-many --target=build --all --parallel --exclude website
	Node 12.x - nx test @typescript-eslint/visitor-keys

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Merging #4117 (ab9a7d8) into master (4875cd6) will increase coverage by 0.60%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4117      +/-   ##
==========================================
+ Coverage   92.73%   93.33%   +0.60%     
==========================================
  Files         334      152     -182     
  Lines       11494     8028    -3466     
  Branches     3270     2576     -694     
==========================================
- Hits        10659     7493    -3166     
+ Misses        362      180     -182     
+ Partials      473      355     -118     

Flag	Coverage Δ
unittest	93.33% <100.00%> (+0.60%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...-plugin/src/rules/explicit-member-accessibility.ts	97.18% <100.00%> (+0.08%)	⬆️
packages/scope-manager/src/lib/es2019.array.ts
packages/scope-manager/src/lib/es2015.promise.ts
packages/scope-manager/src/lib/es2017.intl.ts
...ackages/experimental-utils/src/ts-eslint/ESLint.ts
...perimental-utils/src/ts-eslint-scope/Definition.ts
packages/scope-manager/src/lib/esnext.intl.ts
...ript-estree/src/create-program/createSourceFile.ts
...tal-utils/src/ast-utils/eslint-utils/predicates.ts
packages/scope-manager/src/assert.ts
... and 173 more

[bradzacher]

amazing - thanks for jumping in to fix this!