Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct issues with circular imports #4140

Merged
merged 1 commit into from Nov 15, 2021
Merged

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Nov 15, 2021

PR Checklist

Overview

Ensure that we are not doing circular imports in code-base, this change has been extracted from #4108

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Nov 15, 2021

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 512e520

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/6191c71df56a900008f27023

😎 Browse the preview: https://deploy-preview-4140--typescript-eslint.netlify.app

@armano2 armano2 added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin package: scope-manager Issues related to @typescript-eslint/scope-manager performance Issues regarding performance labels Nov 15, 2021
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #4140 (512e520) into master (87cfc6a) will decrease coverage by 0.43%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4140      +/-   ##
==========================================
- Coverage   93.14%   92.70%   -0.44%     
==========================================
  Files         157      315     +158     
  Lines        8251    10124    +1873     
  Branches     2640     2906     +266     
==========================================
+ Hits         7685     9385    +1700     
- Misses        192      306     +114     
- Partials      374      433      +59     
Flag Coverage Δ
unittest 92.70% <100.00%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/eslint-plugin/src/rules/no-restricted-imports.ts 96.49% <ø> (ø)
...s/eslint-plugin/src/util/collectUnusedVariables.ts 91.94% <100.00%> (ø)
packages/eslint-plugin/src/util/isTypeReadonly.ts 94.44% <100.00%> (+0.07%) ⬆️
...ges/scope-manager/src/referencer/PatternVisitor.ts 68.29% <100.00%> (ø)
packages/eslint-plugin-tslint/src/custom-linter.ts 100.00% <0.00%> (ø)
...s/scope-manager/src/lib/es2020.symbol.wellknown.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2016.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/esnext.string.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/variable/Variable.ts 100.00% <0.00%> (ø)
packages/scope-manager/src/lib/es2020.intl.ts 100.00% <0.00%> (ø)
... and 152 more

@bradzacher bradzacher merged commit 4c87b24 into master Nov 15, 2021
@bradzacher bradzacher deleted the fix/circular-imports branch November 15, 2021 07:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin package: scope-manager Issues related to @typescript-eslint/scope-manager performance Issues regarding performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants