Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename experimental-utils to utils and make experimental-utils an alias to the new package #4172

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Nov 17, 2021

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 2b0b349

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61df5d6baaf9930008fa522a

😎 Browse the preview: https://deploy-preview-4172--typescript-eslint.netlify.app

@nx-cloud
Copy link

nx-cloud bot commented Nov 17, 2021

☁️ Nx Cloud Report

CI ran the following commands for commit 2b0b349. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 26 targets

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #4172 (2b0b349) into main (e61e388) will decrease coverage by 2.86%.
The diff coverage is 99.00%.

@@            Coverage Diff             @@
##             main    #4172      +/-   ##
==========================================
- Coverage   94.26%   91.40%   -2.87%     
==========================================
  Files         169      202      +33     
  Lines        9440     8713     -727     
  Branches     2940     2697     -243     
==========================================
- Hits         8899     7964     -935     
- Misses        321      548     +227     
+ Partials      220      201      -19     
Flag Coverage Δ
unittest 91.40% <99.00%> (-2.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plugin-internal/src/rules/prefer-ast-types-enum.ts 91.30% <ø> (ø)
packages/eslint-plugin/src/rules/brace-style.ts 95.34% <ø> (ø)
...nt-plugin/src/rules/consistent-type-definitions.ts 97.29% <ø> (ø)
...eslint-plugin/src/rules/consistent-type-exports.ts 97.70% <ø> (ø)
...eslint-plugin/src/rules/consistent-type-imports.ts 94.26% <ø> (ø)
packages/eslint-plugin/src/rules/dot-notation.ts 96.29% <ø> (ø)
...-plugin/src/rules/explicit-member-accessibility.ts 97.18% <ø> (ø)
...kages/eslint-plugin/src/rules/func-call-spacing.ts 96.87% <ø> (ø)
...rc/rules/indent-new-do-not-use/BinarySearchTree.ts 100.00% <ø> (ø)
...n/src/rules/indent-new-do-not-use/OffsetStorage.ts 100.00% <ø> (ø)
... and 232 more

@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Nov 17, 2021
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review November 21, 2021 08:27
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing updates in references in:

  • packages/parser/tsconfig.json
  • packages/parser/tsconfig.build.json

@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: create utils package with experimental-utils as alias chore!: create utils package with experimental-utils as alias Nov 21, 2021
@JamesHenry
Copy link
Member

Please never rebase this branch 😅

image

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for all the hard work so far!

Please could you merge in the latest main and fix up the conflicts so we can run the CI workflows, it seems they aren't running on your commits right now and I imagine it's because it predates the master -> main rename?

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Dec 13, 2021
@JoshuaKGoldberg
Copy link
Member Author

Oh hey, CI passed! That's nice.

I ended up rebasing because there were a lot of merge conflicts and I didn't want to sort through them manually. It was much easier to re-apply the same find-and-replace strings and manual touchups from before.

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Jan 11, 2022
@bradzacher
Copy link
Member

bradzacher commented Jan 11, 2022

the package.jsons are conflicting cos of the release bump.
fix those up and we can merge this in!

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like you added cypress artefacts to this PR - I think those are for your other PR?

@JoshuaKGoldberg
Copy link
Member Author

Heh, yes, will remove - been off and on the computer this last week....

@bradzacher bradzacher changed the title chore!: create utils package with experimental-utils as alias chore: create utils package with experimental-utils as alias Jan 12, 2022
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this_is_stampa

@bradzacher bradzacher changed the title chore: create utils package with experimental-utils as alias feat: rename experimental-utils to utils and make experimental-utils an alias to the new package Jan 12, 2022
@bradzacher bradzacher merged commit 1d55a75 into typescript-eslint:main Jan 12, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the drop-the-experimental branch January 12, 2022 23:27
@JamesHenry
Copy link
Member

Bravo 👏

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove 'experimental-' from @typescript-eslint/experimental-utils
3 participants