New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scope-manager): support TS4.5 import/export specifier kind #4234
Conversation
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
❌ Deploy Preview for typescript-eslint failed. 🔨 Explore the source changes: ac9dad3 🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61a56f4e24a4860007845a9c |
0037b13
to
d8fe23e
Compare
@JamesHenry - it looks like something is missing from the netlify build script? |
Codecov Report
@@ Coverage Diff @@
## main #4234 +/- ##
==========================================
+ Coverage 92.73% 93.35% +0.61%
==========================================
Files 335 152 -183
Lines 11542 8056 -3486
Branches 3289 2590 -699
==========================================
- Hits 10704 7521 -3183
+ Misses 364 179 -185
+ Partials 474 356 -118
Flags with carried forward coverage won't be shown. Click here to find out more.
|
8efa5c8
to
689b4b2
Compare
689b4b2
to
ac9dad3
Compare
PR Checklist
Overview
No changes required for import specifier kind as they can be consumed as values or types (same as declaration-level kind).
Export specifier kind required a minor logic change to support.
Also fixed up some of the existing snapshots so they're all consistent