Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scope-manager): support TS4.5 import/export specifier kind #4234

Merged
merged 1 commit into from Dec 2, 2021

Conversation

bradzacher
Copy link
Member

PR Checklist

Overview

No changes required for import specifier kind as they can be consumed as values or types (same as declaration-level kind).
Export specifier kind required a minor logic change to support.
Also fixed up some of the existing snapshots so they're all consistent

@bradzacher bradzacher added the enhancement New feature or request label Nov 29, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Nov 29, 2021

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: ac9dad3

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61a56f4e24a4860007845a9c

@bradzacher
Copy link
Member Author

@JamesHenry - it looks like something is missing from the netlify build script?

@bradzacher bradzacher mentioned this pull request Nov 29, 2021
8 tasks
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #4234 (ac9dad3) into main (9f58eab) will increase coverage by 0.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4234      +/-   ##
==========================================
+ Coverage   92.73%   93.35%   +0.61%     
==========================================
  Files         335      152     -183     
  Lines       11542     8056    -3486     
  Branches     3289     2590     -699     
==========================================
- Hits        10704     7521    -3183     
+ Misses        364      179     -185     
+ Partials      474      356     -118     
Flag Coverage Δ
unittest 93.35% <ø> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/scope-manager/src/referencer/ExportVisitor.ts
...ages/scope-manager/src/lib/es2018.asynciterable.ts
...xperimental-utils/src/ts-eslint-scope/Reference.ts
...ges/experimental-utils/src/ast-utils/predicates.ts
packages/experimental-utils/src/ast-utils/index.ts
...estree/src/create-program/createIsolatedProgram.ts
...src/definition/ImplicitGlobalVariableDefinition.ts
...perimental-utils/src/ts-eslint-scope/Referencer.ts
packages/scope-manager/src/scope/ScopeType.ts
...ope-manager/src/definition/TSEnumNameDefinition.ts
... and 173 more

@bradzacher bradzacher force-pushed the 4.5-specifier-kind-scope branch 2 times, most recently from 8efa5c8 to 689b4b2 Compare November 29, 2021 23:25
@bradzacher bradzacher merged commit 833f822 into main Dec 2, 2021
@bradzacher bradzacher deleted the 4.5-specifier-kind-scope branch December 2, 2021 01:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants