feat(eslint-plugin): [consistent-type-imports] support TS4.5 inline import specifiers

[bradzacher]

PR Checklist

• Addresses an existing issue: TypeScript 4.5 Support #3950
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

• make sure the rule doesn't false-positive for inline type specifiers.
• unlike feat(eslint-plugin): [consistent-type-exports] support TS4.5 inline export specifiers #4236 I didn't add an option for the fixer because the fixer code is SUPER complicated. It would be a huge job to refactor it to support it and I couldn't be bothered right now.

[typescript-eslint]

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[netlify]

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: da02697

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61a820161bfcdf000868cd19

😎 Browse the preview: https://deploy-preview-4237--typescript-eslint.netlify.app

[nx-cloud]

Nx Cloud Report

CI ran the following commands for commit da02697. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
	Node 16.x - nx test @typescript-eslint/eslint-plugin
	Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
	Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
	Node 12.x - nx test @typescript-eslint/eslint-plugin
	Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
	Node 12.x - nx test @typescript-eslint/eslint-plugin
	Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
	Node 14.x - nx test @typescript-eslint/eslint-plugin
	Node 16.x - nx test @typescript-eslint/parser
	Node 12.x - nx test @typescript-eslint/parser
	Node 12.x - nx test @typescript-eslint/experimental-utils
	Node 12.x - nx test @typescript-eslint/scope-manager
	Node 12.x - nx test @typescript-eslint/visitor-keys
	Node 16.x - nx test @typescript-eslint/experimental-utils
	Node 12.x - nx test @typescript-eslint/typescript-estree
	Node 16.x - nx test @typescript-eslint/scope-manager
	Node 16.x - nx test @typescript-eslint/visitor-keys
	Node 16.x - nx test @typescript-eslint/typescript-estree
	Node 12.x - nx test @typescript-eslint/parser

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Merging #4237 (da02697) into main (833f822) will decrease coverage by 0.01%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             main    #4237      +/-   ##
==========================================
- Coverage   93.32%   93.31%   -0.02%     
==========================================
  Files         169      169              
  Lines        9440     9454      +14     
  Branches     2963     2967       +4     
==========================================
+ Hits         8810     8822      +12     
- Misses        235      236       +1     
- Partials      395      396       +1     

Flag	Coverage Δ
unittest	93.31% <93.33%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...eslint-plugin/src/rules/consistent-type-imports.ts	93.03% <93.33%> (-0.45%)	⬇️

[gajus]

Seems like this failed for unrelated reasons. How do we re-run the pipeline?

[akphi]

@bradzacher would you accept a PR for a boolean flag that enforces prefer using mixed mode when possible? For example:

e.g. @typescript-eslint/consistent-type-imports: ["error", { "preferMixedTypeImports": true }],

// ERROR
import type { c } from './c';
import { a } from './a'; 
import type { b } from './a';

// NO ERROR
import type { c } from './c';
import { a, type b } from './a'; 

As you said, a fixer is complicated, but for folks who want to use this new syntax, I imagine this could be a useful at least.

[bradzacher]

please file an issue to discuss this, as per our contributing guidelines.