Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [no-shadow] support TS4.5 inline import specifiers #4239

Merged
merged 2 commits into from Dec 6, 2021

Conversation

bradzacher
Copy link
Member

PR Checklist

Overview

simple change to support it

@bradzacher bradzacher added the enhancement New feature or request label Nov 30, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Nov 30, 2021

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: d4ecbf7

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61a82015c0d3f800076a5bd4

😎 Browse the preview: https://deploy-preview-4239--typescript-eslint.netlify.app

@bradzacher bradzacher mentioned this pull request Nov 30, 2021
8 tasks
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #4239 (d4ecbf7) into main (9f58eab) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4239   +/-   ##
=======================================
  Coverage   92.73%   92.74%           
=======================================
  Files         335      336    +1     
  Lines       11542    11548    +6     
  Branches     3289     3290    +1     
=======================================
+ Hits        10704    10710    +6     
  Misses        364      364           
  Partials      474      474           
Flag Coverage Δ
unittest 92.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/no-shadow.ts 76.33% <ø> (ø)
packages/scope-manager/src/lib/dom.iterable.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/dom.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/es5.ts 100.00% <ø> (ø)
...ckages/scope-manager/src/lib/webworker.iterable.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/webworker.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/es2021.intl.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2021.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/index.ts 100.00% <100.00%> (ø)
...ages/scope-manager/src/referencer/ExportVisitor.ts 90.90% <100.00%> (+0.90%) ⬆️

@bradzacher bradzacher merged commit 96b7e8e into main Dec 6, 2021
@bradzacher bradzacher deleted the 4.5-no-shadow-support branch December 6, 2021 18:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant