Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [padding-line-between-statements] type StatementTypes can't differenciate from variable #4270

Merged
merged 4 commits into from Dec 20, 2021
Merged

fix(eslint-plugin): [padding-line-between-statements] type StatementTypes can't differenciate from variable #4270

merged 4 commits into from Dec 20, 2021

Conversation

lonyele
Copy link
Contributor

@lonyele lonyele commented Dec 7, 2021 •
edited

PR Checklist

Overview

Problem

keyword type is not always the reserved word from TS which makes the situation like const type = 'whatever string' possible.

What I did

checking both node's token value and its type. It makes the situation like token VariableDeclaration'ed type keyword and TSTypeAliasDeclaration'ed type keyword impossible

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @lonyele!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Dec 7, 2021 •
edited

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: da3676e

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61afea1550bdce00082ae4ba

@nx-cloud
Copy link

nx-cloud bot commented Dec 7, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit da3676e. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 16.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 16.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 16.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx test @typescript-eslint/typescript-estree
#000000 Node 16.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Dec 7, 2021 •
edited

Codecov Report

Merging #4270 (da3676e) into main (9c22f65) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main    #4270   +/-   ##
=======================================
  Coverage   93.37%   93.37%           
=======================================
  Files         152      152           
  Lines        8085     8088    +3     
  Branches     2596     2598    +2     
=======================================
+ Hits         7549     7552    +3     
  Misses        181      181           
  Partials      355      355
Flag Coverage Δ
unittest 93.37% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin/src/rules/padding-line-between-statements.ts 91.09% <75.00%> (+0.18%) ⬆️

@bradzacher bradzacher added the bug Something isn't working label Dec 7, 2021
bradzacher
bradzacher approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

@bradzacher bradzacher merged commit bfc4324 into typescript-eslint:main Dec 20, 2021
@lonyele lonyele deleted the fix/type-variable-working-as-statement-type branch December 24, 2021 09:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[padding-line-between-statements] Wrong blank line for property called "type"
2 participants
@lonyele @bradzacher