New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): array-type
mark AST_NODE_TYPES.TSBigIntKeyword
as simple
#4274
fix(eslint-plugin): array-type
mark AST_NODE_TYPES.TSBigIntKeyword
as simple
#4274
Conversation
Thanks for the PR, @jonahsnider! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
❌ Deploy Preview for typescript-eslint failed. 🔨 Explore the source changes: f8899b4 🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61b937291547e60007828802 |
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #4274 +/- ##
==========================================
+ Coverage 93.15% 93.37% +0.21%
==========================================
Files 174 152 -22
Lines 9684 8085 -1599
Branches 3029 2596 -433
==========================================
- Hits 9021 7549 -1472
+ Misses 249 181 -68
+ Partials 414 355 -59
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this and adding all of the test cases!
Overview
The
array-type
rule has a list of several types that are marked as "simple" (ex. number, boolean, string, etc).This PR adds
bigint
s viaAST_NODE_TYPES.TSBigIntKeyword
to that list.This means that
is now considered a simple array.