Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): array-type mark AST_NODE_TYPES.TSBigIntKeyword as simple #4274

Merged
merged 3 commits into from Dec 15, 2021
Merged

fix(eslint-plugin): array-type mark AST_NODE_TYPES.TSBigIntKeyword as simple #4274

merged 3 commits into from Dec 15, 2021

Conversation

jonahsnider
Copy link
Contributor

Overview

The array-type rule has a list of several types that are marked as "simple" (ex. number, boolean, string, etc).

This PR adds bigints via AST_NODE_TYPES.TSBigIntKeyword to that list.

This means that

type T = bigint[];

is now considered a simple array.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @jonahsnider!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Dec 8, 2021

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: f8899b4

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61b937291547e60007828802

@nx-cloud
Copy link

nx-cloud bot commented Dec 8, 2021

@armano2

This comment has been minimized.

@bradzacher bradzacher added awaiting response Issues waiting for a reply from the OP or another party bug Something isn't working labels Dec 9, 2021
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #4274 (f8899b4) into main (9c3befb) will increase coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4274      +/-   ##
==========================================
+ Coverage   93.15%   93.37%   +0.21%     
==========================================
  Files         174      152      -22     
  Lines        9684     8085    -1599     
  Branches     3029     2596     -433     
==========================================
- Hits         9021     7549    -1472     
+ Misses        249      181      -68     
+ Partials      414      355      -59     
Flag Coverage Δ
unittest 93.37% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/array-type.ts 97.18% <ø> (ø)
...-estree/src/create-program/createDefaultProgram.ts
...ckages/typescript-estree/src/jsx/xhtml-entities.ts
packages/typescript-estree/src/simple-traverse.ts
...escript-estree/src/semantic-or-syntactic-errors.ts
...pt-estree/src/create-program/createWatchProgram.ts
...-internal/src/rules/no-typescript-estree-import.ts
packages/typescript-estree/src/convert-comments.ts
...-estree/src/create-program/createProjectProgram.ts
...plugin-internal/src/rules/prefer-ast-types-enum.ts
... and 13 more

@armano2 armano2 removed the awaiting response Issues waiting for a reply from the OP or another party label Dec 15, 2021
@armano2 armano2 added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label Dec 15, 2021
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this and adding all of the test cases!

@bradzacher bradzacher merged commit 74e544e into typescript-eslint:main Dec 15, 2021
@jonahsnider jonahsnider deleted the fix/array-type-bigint branch December 15, 2021 08:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants