Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): handle method overloading in semi #4318

Merged
merged 1 commit into from Dec 20, 2021

Conversation

yeonjuan
Copy link
Contributor

PR Checklist

Overview

fixes #4317

@nx-cloud
Copy link

nx-cloud bot commented Dec 16, 2021

☁️ Nx Cloud Report

CI ran the following commands for commit d545ef7. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 44 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Dec 16, 2021

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: d545ef7

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61bb5faad01e2400073fb1f8

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #4318 (d545ef7) into main (9f58eab) will increase coverage by 1.45%.
The diff coverage is 94.87%.

@@            Coverage Diff             @@
##             main    #4318      +/-   ##
==========================================
+ Coverage   92.73%   94.19%   +1.45%     
==========================================
  Files         335      152     -183     
  Lines       11542     8090    -3452     
  Branches     3289     2586     -703     
==========================================
- Hits        10704     7620    -3084     
+ Misses        364      266      -98     
+ Partials      474      204     -270     
Flag Coverage Δ
unittest 94.19% <94.87%> (+1.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/array-type.ts 97.18% <ø> (ø)
...kages/eslint-plugin/src/rules/no-empty-function.ts 80.00% <ø> (ø)
packages/eslint-plugin/src/rules/no-shadow.ts 76.33% <ø> (ø)
packages/eslint-plugin/src/rules/semi.ts 92.85% <ø> (ø)
...eslint-plugin/src/rules/consistent-type-imports.ts 94.26% <93.33%> (+0.78%) ⬆️
...eslint-plugin/src/rules/consistent-type-exports.ts 97.70% <94.44%> (+1.86%) ⬆️
...ackages/eslint-plugin/src/rules/no-implied-eval.ts 97.05% <100.00%> (+2.94%) ⬆️
...ckages/eslint-plugin/src/rules/no-magic-numbers.ts 84.31% <100.00%> (+1.96%) ⬆️
...int-plugin/src/rules/strict-boolean-expressions.ts 98.81% <100.00%> (+0.03%) ⬆️
... and 240 more

@armano2 armano2 added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin labels Dec 17, 2021
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

@bradzacher bradzacher merged commit 3b87b49 into typescript-eslint:main Dec 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[semi] Won't trigger on semicolons after overrides
3 participants