feat(eslint-plugin): add `no-useless-empty-export` rule #4380

JoshuaKGoldberg · 2021-12-31T22:08:38Z

PR Checklist

Addresses an existing issue: fixes New rule: no-useless-empty-export #2757
That issue was marked as accepting prs
Steps in CONTRIBUTING.md were taken

Overview

Adds a fun little new rule.

Intentionally only targets the useless export {} case. Targeting accidental global pollution is a more nuanced issue that should probably get its own issue+discussion+rule.

nx-cloud · 2021-12-31T22:08:40Z

☁️ Nx Cloud Report

CI ran the following commands for commit e909d2a. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 48 targets

Sent with 💌 from NxCloud.

typescript-eslint · 2021-12-31T22:08:42Z

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

netlify · 2021-12-31T22:08:45Z

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: e909d2a

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/621699ef6da9430008f1c2eb

😎 Browse the preview: https://deploy-preview-4380--typescript-eslint.netlify.app

packages/eslint-plugin/src/rules/no-useless-empty-export.ts

codecov · 2022-01-01T17:39:58Z

Codecov Report

Merging #4380 (e909d2a) into main (0c63f26) will increase coverage by 0.35%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4380      +/-   ##
==========================================
+ Coverage   94.26%   94.62%   +0.35%     
==========================================
  Files         169      148      -21     
  Lines        9511     7932    -1579     
  Branches     2973     2546     -427     
==========================================
- Hits         8966     7506    -1460     
+ Misses        322      234      -88     
+ Partials      223      192      -31

Flag	Coverage Δ
unittest	`94.62% <100.00%> (+0.35%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/configs/all.ts	`100.00% <ø> (ø)`
...eslint-plugin/src/rules/no-useless-empty-export.ts	`100.00% <100.00%> (ø)`
packages/typescript-estree/src/convert-comments.ts
...lugin-internal/src/rules/plugin-test-formatting.ts
...plugin-internal/src/rules/prefer-ast-types-enum.ts
packages/typescript-estree/src/simple-traverse.ts
...-estree/src/create-program/createDefaultProgram.ts
packages/typescript-estree/src/version-check.ts
...estree/src/create-program/createIsolatedProgram.ts
...pt-estree/src/create-program/createWatchProgram.ts
... and 14 more

bradzacher

LGTM - one comment.
Feel free to merge once addressed!

packages/eslint-plugin/tests/rules/no-useless-empty-export.test.ts

…t.ts Co-authored-by: Brad Zacher <brad.zacher@gmail.com>

JoshuaKGoldberg · 2022-02-23T20:44:58Z

@bradzacher, sorry, the review got wiped. Could you ✔️ again please? 😄

Same with #4378

bradzacher

feel free to use your admin rights to merge if i've already stamped.
you needn't wait for a re-review for trivial changes :)

JoshuaKGoldberg · 2022-02-23T23:59:01Z

I... don't think I have those admin rights? Maybe it's an auto-merge weirdness. I'll ping you separately if I need. Thanks!

JoshuaKGoldberg · 2022-02-23T23:59:43Z

Ah, this: #4503 (comment)

…slint#4380)

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.12.1` -> `5.13.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.12.1/5.13.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.12.1` -> `5.13.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.12.1/5.13.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v5.13.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5130-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5121v5130-2022-02-28) [Compare Source](typescript-eslint/typescript-eslint@v5.12.1...v5.13.0) ##### Bug Fixes - **eslint-plugin:** \[sort-type-union-intersection-members] Wrap the constructorType in parentheses ([#4590](typescript-eslint/typescript-eslint#4590)) ([851bb90](typescript-eslint/typescript-eslint@851bb90)) ##### Features - **eslint-plugin:** \[no-misused-promises] check more places for checksVoidReturn ([#4541](typescript-eslint/typescript-eslint#4541)) ([052cf51](typescript-eslint/typescript-eslint@052cf51)) - **eslint-plugin:** add `no-redundant-type-constituents` rule ([#4378](typescript-eslint/typescript-eslint#4378)) ([63d051e](typescript-eslint/typescript-eslint@63d051e)) - **eslint-plugin:** add `no-useless-empty-export` rule ([#4380](typescript-eslint/typescript-eslint#4380)) ([823b945](typescript-eslint/typescript-eslint@823b945)) - **eslint-plugin:** add extension rule `space-before-blocks` ([#1606](typescript-eslint/typescript-eslint#1606)) ([#4184](typescript-eslint/typescript-eslint#4184)) ([208b6d0](typescript-eslint/typescript-eslint@208b6d0)) - **eslint-plugin:** added member group support to member-ordering rule ([#4538](typescript-eslint/typescript-eslint#4538)) ([6afcaea](typescript-eslint/typescript-eslint@6afcaea)) #### [5.12.1](typescript-eslint/typescript-eslint@v5.12.0...v5.12.1) (2022-02-21) ##### Bug Fixes - **eslint-plugin:** \[no-unnecessary-type-arguments] fix comparison of types ([#4555](typescript-eslint/typescript-eslint#4555)) ([fc3936e](typescript-eslint/typescript-eslint@fc3936e)) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v5.13.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5130-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5121v5130-2022-02-28) [Compare Source](typescript-eslint/typescript-eslint@v5.12.1...v5.13.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) #### [5.12.1](typescript-eslint/typescript-eslint@v5.12.0...v5.12.1) (2022-02-21) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Co-authored-by: 6543 <6543@noreply.codeberg.org> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1192 Reviewed-by: 6543 <6543@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

feat(eslint-plugin): add no-useless-empty-export rule

a67eb47

bradzacher added the enhancement: new plugin rule New rule request for eslint-plugin label Jan 1, 2022

bradzacher reviewed Jan 1, 2022

View reviewed changes

packages/eslint-plugin/src/rules/no-useless-empty-export.ts Outdated Show resolved Hide resolved

chore: handle module declarations and fix table list

7896f4f

JoshuaKGoldberg and others added 2 commits January 2, 2022 15:06

chore: add empty body case

4181694

Merge branch 'main' into no-useless-empty-export

fa7c2c7

JoshuaKGoldberg marked this pull request as ready for review January 2, 2022 20:29

JoshuaKGoldberg requested a review from bradzacher January 2, 2022 20:29

Josh Goldberg and others added 4 commits January 2, 2022 15:30

Merge branch 'main' into no-useless-empty-export

04ff072

Merge branch 'main' into no-useless-empty-export

0501bea

Merge branch 'main' into no-useless-empty-export

2412ab4

chore: update utils package name in no-useless-empty-export.ts

a6c635d

bradzacher previously approved these changes Feb 2, 2022

View reviewed changes

packages/eslint-plugin/tests/rules/no-useless-empty-export.test.ts Show resolved Hide resolved

bradzacher added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label Feb 2, 2022

Update packages/eslint-plugin/tests/rules/no-useless-empty-export.tes…

b4e7ddf

…t.ts Co-authored-by: Brad Zacher <brad.zacher@gmail.com>

JoshuaKGoldberg dismissed bradzacher’s stale review via b4e7ddf February 2, 2022 20:53

Merge branch 'main' into no-useless-empty-export

225e5aa

JoshuaKGoldberg enabled auto-merge (squash) February 2, 2022 20:54

JoshuaKGoldberg disabled auto-merge February 23, 2022 20:30

JoshuaKGoldberg added 2 commits February 23, 2022 15:30

Merge branch 'main' into no-useless-empty-export

2509b70

docs: corrected docs file

e909d2a

JoshuaKGoldberg enabled auto-merge (squash) February 23, 2022 20:32

JoshuaKGoldberg requested a review from bradzacher February 23, 2022 20:44

bradzacher approved these changes Feb 23, 2022

View reviewed changes

bradzacher disabled auto-merge February 23, 2022 23:40

bradzacher merged commit 823b945 into typescript-eslint:main Feb 23, 2022

JoshuaKGoldberg deleted the no-useless-empty-export branch February 23, 2022 23:58

JoshuaKGoldberg added a commit to JoshuaKGoldberg/typescript-eslint that referenced this pull request Feb 27, 2022

feat(eslint-plugin): add no-useless-empty-export rule (typescript-e…

22dd165

…slint#4380)

github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-plugin): add `no-useless-empty-export` rule #4380

feat(eslint-plugin): add `no-useless-empty-export` rule #4380

JoshuaKGoldberg commented Dec 31, 2021

nx-cloud bot commented Dec 31, 2021 •

edited

typescript-eslint bot commented Dec 31, 2021

netlify bot commented Dec 31, 2021 •

edited

codecov bot commented Jan 1, 2022 •

edited

bradzacher left a comment

JoshuaKGoldberg commented Feb 23, 2022

bradzacher left a comment

JoshuaKGoldberg commented Feb 23, 2022

JoshuaKGoldberg commented Feb 23, 2022

feat(eslint-plugin): add no-useless-empty-export rule #4380

feat(eslint-plugin): add no-useless-empty-export rule #4380

Conversation

JoshuaKGoldberg commented Dec 31, 2021

PR Checklist

Overview

nx-cloud bot commented Dec 31, 2021 • edited

☁️ Nx Cloud Report

typescript-eslint bot commented Dec 31, 2021

netlify bot commented Dec 31, 2021 • edited

codecov bot commented Jan 1, 2022 • edited

Codecov Report

bradzacher left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg commented Feb 23, 2022

bradzacher left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg commented Feb 23, 2022

JoshuaKGoldberg commented Feb 23, 2022

feat(eslint-plugin): add `no-useless-empty-export` rule #4380

feat(eslint-plugin): add `no-useless-empty-export` rule #4380

nx-cloud bot commented Dec 31, 2021 •

edited

netlify bot commented Dec 31, 2021 •

edited

codecov bot commented Jan 1, 2022 •

edited