Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): restrict-plus-operands: generic constraint support #440

Merged
merged 2 commits into from Apr 24, 2019
Merged

fix(eslint-plugin): restrict-plus-operands: generic constraint support #440

merged 2 commits into from Apr 24, 2019

Conversation

bradzacher
Copy link
Member

Fixes #230

@bradzacher bradzacher added the bug Something isn't working label Apr 19, 2019
JamesHenry
JamesHenry approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #440 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
+ Coverage   97.09%   97.09%   +<.01%     
==========================================
  Files          77       77              
  Lines        2928     2931       +3     
  Branches      483      484       +1     
==========================================
+ Hits         2843     2846       +3     
  Misses         52       52              
  Partials       33       33
Impacted Files Coverage Δ
.../eslint-plugin/src/rules/restrict-plus-operands.ts 96.55% <100%> (+0.39%) ⬆️

@JamesHenry JamesHenry merged commit 3f305b1 into master Apr 24, 2019
@JamesHenry JamesHenry deleted the 230-rpo-generics branch April 24, 2019 13:39
@bradzacher bradzacher mentioned this pull request Nov 18, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[restrict-plus-operands] false positive on type parameters
2 participants
@bradzacher @JamesHenry