New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [no-magic-numbers] handle bigint in class props #4411
Conversation
Thanks for the PR, @a-tarasyuk! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
❌ Deploy Preview for typescript-eslint failed. 🔨 Explore the source changes: 3d4550b 🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61d9b8b3a9f26000074ca217 |
Codecov Report
@@ Coverage Diff @@
## main #4411 +/- ##
==========================================
+ Coverage 91.95% 94.61% +2.66%
==========================================
Files 346 147 -199
Lines 11622 7841 -3781
Branches 3298 2507 -791
==========================================
- Hits 10687 7419 -3268
+ Misses 675 233 -442
+ Partials 260 189 -71
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing this!
Fixes #4389