Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): no-inferrable-types: Support more primitives #442

Merged
merged 4 commits into from May 9, 2019

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Apr 19, 2019

Fixes #321

I was looking, and noticed a number of missing primitives and cases in no-inferrable-types.

This just adds support for more "easily inferable types":

  • bigint
  • null
  • regexp
  • string template expressions (not tagged templates though).
  • symbol
  • undefined

Also adds support across the board for the global constructor functions, and more unary expressions.

@bradzacher bradzacher added the enhancement New feature or request label Apr 19, 2019
@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #442 into master will increase coverage by 0.15%.
The diff coverage is 94.59%.

@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
+ Coverage   95.73%   95.88%   +0.15%     
==========================================
  Files          79       79              
  Lines        3613     3625      +12     
  Branches     1013     1020       +7     
==========================================
+ Hits         3459     3476      +17     
+ Misses         53       51       -2     
+ Partials      101       98       -3
Impacted Files Coverage Δ
...ges/eslint-plugin/src/rules/no-inferrable-types.ts 93.1% <94.59%> (+12.66%) ⬆️

@bradzacher bradzacher merged commit 4e193ca into master May 9, 2019
@bradzacher bradzacher deleted the more-no-inferrable-type branch May 9, 2019 16:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-inferrable-types] Boolean initialized to null tagged as inferrable
2 participants