fix(eslint-plugin): [no-invalid-this] crash when used with eslint 8.7.0

[ota-meshi]

PR Checklist

• Addresses an existing issue: fixes no-invalid-this issue exception after upgrading to eslint 8.7.0 #4444
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Changed not to call the deleted method to prevent the no-invalid-this rule from crashing. As far as I can see the implementation of the core rule, I think it works fine.

[typescript-eslint]

Thanks for the PR, @ota-meshi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[nx-cloud]

☁️ Nx Cloud Report

CI ran the following commands for commit bb42059. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 48 targets

• Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 16.x - nx test @typescript-eslint/eslint-plugin
• Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 12.x - nx test @typescript-eslint/eslint-plugin
• Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 14.x - nx test @typescript-eslint/eslint-plugin
• Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
• Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 12.x - nx test @typescript-eslint/eslint-plugin
• Node 12.x - nx run-many --target=typecheck --all --parallel
• Node 16.x - nx test @typescript-eslint/parser
• Node 16.x - nx test @typescript-eslint/type-utils
• Node 16.x - nx test @typescript-eslint/utils
• Node 16.x - nx test @typescript-eslint/scope-manager
• Node 16.x - nx test @typescript-eslint/visitor-keys
• Node 16.x - nx test @typescript-eslint/typescript-estree
• Node 16.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14.x - nx test @typescript-eslint/parser
• Node 14.x - nx test @typescript-eslint/type-utils
• Node 14.x - nx test @typescript-eslint/utils
• Node 14.x - nx test @typescript-eslint/scope-manager
• Node 14.x - nx test @typescript-eslint/visitor-keys
• Node 14.x - nx test @typescript-eslint/typescript-estree
• Node 14.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx test @typescript-eslint/parser
• Node 12.x - nx test @typescript-eslint/type-utils
• Node 12.x - nx test @typescript-eslint/utils
• Node 16.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx test @typescript-eslint/scope-manager
• Node 12.x - nx test @typescript-eslint/visitor-keys
• Node 12.x - nx test @typescript-eslint/typescript-estree
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx test @typescript-eslint/parser
• Node 12.x - nx test @typescript-eslint/type-utils
• Node 12.x - nx test @typescript-eslint/utils
• Node 12.x - nx test @typescript-eslint/scope-manager
• Node 12.x - nx test @typescript-eslint/visitor-keys
• Node 12.x - nx test @typescript-eslint/typescript-estree
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types

---

Sent with 💌 from NxCloud.

[netlify]

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: bb42059

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61e527a619500d000796619a

[ota-meshi]

The no-extra-semi rule has also changed and needs to be fixed. I will open PR.
eslint/eslint#15287

[bradzacher]

@ota-meshi - feel free to fix it in this PR as well for ease of updating.

[ota-meshi]

I reverted the version of eslint to make it easier to merge this PR.
We can later upgrade the eslint v8.7.0 with #4458.
We can see from the previous action result that no-invalid-this changed in this PR works with eslint v8.7.0.
https://github.com/typescript-eslint/typescript-eslint/runs/4837743893

[codecov]

Codecov Report

Merging #4448 (bb42059) into main (d053cde) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #4448      +/-   ##
==========================================
- Coverage   94.62%   94.57%   -0.06%     
==========================================
  Files         147      147              
  Lines        7849     7849              
  Branches     2511     2515       +4     
==========================================
- Hits         7427     7423       -4     
  Misses        233      233              
- Partials      189      193       +4     

Flag	Coverage Δ
unittest	94.57% <0.00%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ackages/eslint-plugin/src/rules/no-invalid-this.ts	80.00% <0.00%> (-16.00%)	⬇️

[ota-meshi]

I find it difficult for me to prevent a loss of coverage as the code covered changes with each version of eslint 😅

[bradzacher]

thanks for this!