Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unified-signatures] false positive on async functions #452

Closed
mysticatea opened this issue Apr 22, 2019 · 1 comment
Closed

[unified-signatures] false positive on async functions #452

mysticatea opened this issue Apr 22, 2019 · 1 comment
Labels
bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@mysticatea
Copy link
Member

Repro

{
  "rules": {
    "@typescript-eslint/unified-signatures": "error"
  }
}
interface Table<T> {
    getById(ids: ReadonlyArray<string>): Promise<Map<string, T>>
    getById(id: string): Promise<T | undefined>
}

Expected Result

No errors.

Actual Result

3:13  error  These overloads can be combined into one signature taking `ReadonlyArray<string> | string`  @typescript-eslint/unified-signatures

Additional Info

Versions

package version
@typescript-eslint/eslint-plugin 1.7.0
@typescript-eslint/parser 1.7.0
TypeScript 3.4.3
ESLint 5.16.0
node 10.15.3
npm 6.9.0
@mysticatea mysticatea added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Apr 22, 2019
@bradzacher bradzacher added bug Something isn't working and removed triage Waiting for maintainers to take a look labels Apr 22, 2019
@bradzacher
Copy link
Member

This was fixed in #839

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

No branches or pull requests

2 participants