Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin:@typescript-eslint/recommended] Semver violation #473

Closed
mysticatea opened this issue Apr 25, 2019 · 2 comments
Closed

[plugin:@typescript-eslint/recommended] Semver violation #473

mysticatea opened this issue Apr 25, 2019 · 2 comments
Labels
awaiting response Issues waiting for a reply from the OP or another party package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@mysticatea
Copy link
Member

As I mentioned in #354 (comment), adding new rules to the recommended config is a breaking change that needs major version up.

But v1.7.0 seemed to add new rules to the recommended config.

Please revert the change of the recommended config and make a patch release.
@mysticatea mysticatea added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Apr 25, 2019
@bradzacher bradzacher added awaiting response Issues waiting for a reply from the OP or another party and removed triage Waiting for maintainers to take a look labels Apr 26, 2019
@bradzacher
Copy link
Member

It shouldn't have.
https://github.com/typescript-eslint/typescript-eslint/commits/master/packages/eslint-plugin/src/configs/recommended.json

The file hasn't been changed in over 2 months.

I just did a clean install of 1.7.0 and the recommended.json is exactly the same as what is in master right now.

Could you please compare your recommended.json vs master and let me know if you're seeing something different?

@mysticatea
Copy link
Member Author

Oh, I apologize.
I had not confirmed code enough after I had seen some tweets.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
awaiting response Issues waiting for a reply from the OP or another party package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mysticatea @bradzacher