feat: remove semantically invalid properties from TSEnumDeclaration, TSInterfaceDeclaration and TSModuleDeclaration

[juank1809]

BREAKING CHANGE:
Removes properties from AST node types.

---

PR Checklist

• Addresses an existing open issue: fixes Remove properties that are used by invalid code #4759
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Remove incorrect and useless properties from the AST nodes as we are not erroring this kind of semantically code; additionally removed one deprecated function in the converter file that used unsuitable modifiers for TSModuleDeclaration, TSEnumDeclaration and TSInterfaceDeclaration and instead used the utility hasModifier function to handle the const and declare properties when we are analyzing these typescript AST nodes.

The only code I trace using these invalid properties outside the typescript-estree package was in the scope-manager handling wrong interface inheritance.
Some snapshots were re-written as expected.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a69faeb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 46 targets

• Node 14 - nx test @typescript-eslint/eslint-plugin --coverage=false
• Node 18 - nx test @typescript-eslint/eslint-plugin
• Node 18 - nx test @typescript-eslint/typescript-estree
• Node 18 - nx test @typescript-eslint/scope-manager
• Node 18 - nx test @typescript-eslint/type-utils
• Node 14 - nx test @typescript-eslint/typescript-estree --coverage=false
• Node 18 - nx test @typescript-eslint/visitor-keys
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/utils
• Node 18 - nx test @typescript-eslint/parser
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/eslint-plugin-tslint
• Node 18 - nx test @typescript-eslint/eslint-plugin-internal
• Node 14 - nx test @typescript-eslint/utils --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/scope-manager --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/type-utils --coverage=false
• Node 18 - nx test @typescript-eslint/ast-spec
• nx run-many --target=typecheck --all --parallel
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/visitor-keys --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/eslint-plugin-internal --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/parser --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/eslint-plugin-tslint --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/ast-spec --coverage=false
• nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[typescript-eslint]

Thanks for the PR, @juank1809!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[netlify]

❌ Deploy Preview for typescript-eslint failed.

Name	Link
🔨 Latest commit	7ca78b1
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/62850820c3448b0008178113

[codecov]

Codecov Report

Merging #4863 (a69faeb) into v6 (04488c2) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##               v6    #4863      +/-   ##
==========================================
- Coverage   91.36%   91.34%   -0.03%     
==========================================
  Files         364      364              
  Lines       12143    12125      -18     
  Branches     3543     3540       -3     
==========================================
- Hits        11095    11076      -19     
- Misses        748      749       +1     
  Partials      300      300              

Flag	Coverage Δ
unittest	91.34% <100.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ckages/scope-manager/src/referencer/TypeVisitor.ts	98.98% <ø> (+0.98%)	⬆️
packages/typescript-estree/src/convert.ts	97.59% <100.00%> (-0.32%)	⬇️

[armano2]

can you remove Modifiers from ast types?

[JoshuaKGoldberg]

Great, thanks for this @juank1809!

We're starting work on v6 now, so I'll merge this into the v6 branch. Woop!