fix(typescript-estree): ensure parents are defined #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #500 +/- ##
==========================================
+ Coverage 95.76% 95.76% +<.01%
==========================================
Files 78 78
Lines 3491 3493 +2
Branches 963 963
==========================================
+ Hits 3343 3345 +2
Misses 53 53
Partials 95 95
|
bradzacher
approved these changes
May 8, 2019
|
@bradzacher This is actually done frequently inside the TS language service... it's basically the canonical way of forcing parent pointers to be bound 🤢 |
|
Haha a canonical hack is the best kind of hack! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #498
When getting the updated program from the TS watch program, it doesn't automatically set parent pointers in the contained source files (which we then traverse as ASTs). By getting the type checker, it triggers a side effect to set those parent pointers.