Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [member-delimiter-style] autofixer result is not as expected when comments after the delimiter with option delimiter: 'none' #5029

Merged

Conversation

holazz
Copy link
Contributor

@holazz holazz commented May 21, 2022

PR Checklist

Overview

…as expected when comments after the delimiter with option `delimiter: 'none'`
@nx-cloud
Copy link

nx-cloud bot commented May 21, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fd8748c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @holazz!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented May 21, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit fd8748c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6288a88a2e30ed0009854066
😎 Deploy Preview https://deploy-preview-5029--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #5029 (fd8748c) into main (9f3121b) will increase coverage by 2.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5029      +/-   ##
==========================================
+ Coverage   91.68%   93.79%   +2.10%     
==========================================
  Files         361      286      -75     
  Lines       12128     9803    -2325     
  Branches     3521     2932     -589     
==========================================
- Hits        11120     9195    -1925     
+ Misses        658      328     -330     
+ Partials      350      280      -70     
Flag Coverage Δ
unittest 93.79% <100.00%> (+2.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../eslint-plugin/src/rules/member-delimiter-style.ts 94.73% <100.00%> (+0.61%) ⬆️
...-internal/src/rules/no-typescript-estree-import.ts
packages/visitor-keys/src/get-keys.ts
packages/type-utils/src/predicates.ts
packages/typescript-estree/src/convert.ts
packages/type-utils/src/getSourceFileOfNode.ts
packages/eslint-plugin-tslint/src/rules/config.ts
...ges/type-utils/src/getConstrainedTypeAtLocation.ts
...ges/typescript-estree/src/create-program/shared.ts
packages/utils/src/ts-eslint/index.ts
... and 66 more

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit ed7b5f6 into typescript-eslint:main May 21, 2022
@holazz holazz deleted the fix/member-delimiter-style branch May 22, 2022 07:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants