Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: when should version 6 release? #5037

Closed
JoshuaKGoldberg opened this issue May 22, 2022 · 2 comments
Closed

Discussion: when should version 6 release? #5037

JoshuaKGoldberg opened this issue May 22, 2022 · 2 comments
Labels
breaking change This change will require a new major version to be released question Questions! (i.e. not a bug / enhancment / documentation)

Comments

@JoshuaKGoldberg
Copy link
Member

Overview

Following discussions in #5032 and #5036: it's been 7 months since 5.0 was released. We've got a few open breaking change issues and pending breaking change PRs. How frequently / at what point should we release breaking changes?

Starting strawperson proposal: how about once a year? That would give us time to tackle larger issues such as #1417 and #1852.

@JoshuaKGoldberg JoshuaKGoldberg added question Questions! (i.e. not a bug / enhancment / documentation) breaking change This change will require a new major version to be released labels May 22, 2022
@bradzacher
Copy link
Member

bradzacher commented May 22, 2022

Traditionally we haven't done major releases on a timeline because it's hard for any of us to commit time on any regular schedule.

In the past it's really been whenever there was some pressing need to do one (like requirements for a new TS version).

I had hoped that I would have time enough to get the AST enforcement in, but it'll be a while before I can truly tackle that.

So if we have anything that we want to do sooner rather than later, we can start the process now!

The general process for a major release has been

  1. branch from main with the name v\d+
  2. setup a canary release from this branch to a tag rc-v\d+
  3. start merging until we've ticked off all of the issues we want.
  4. let it bake in RC for a week or so and publicise it to get community eyes on it.
  5. release! (this I think might take some manual intervention from memory - James usually hops in to do it IIRC)

Side note - lerna (which we use to bump our versions and do the release logs) doesn't support the feat!: syntax for breaking changes (sadly). Instead they mark a commit as breaking if the commit message starts with BREAKING CHANGE:.

One of our previous releases we used the ! syntax and james had to manually clean up the release notes and everything - it was very messy!

@JoshuaKGoldberg
Copy link
Member Author

I've started working on this in #5883, and we started documentation in #5874. This issue can be closed. ✨

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change will require a new major version to be released question Questions! (i.e. not a bug / enhancment / documentation)
Projects
None yet
Development

No branches or pull requests

2 participants