-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [space-infix-ops] regression fix for conditional types #5135
fix(eslint-plugin): [space-infix-ops] regression fix for conditional types #5135
Conversation
Thanks for the PR, @armano2! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #5135 +/- ##
==========================================
+ Coverage 91.32% 93.83% +2.50%
==========================================
Files 132 286 +154
Lines 1487 9839 +8352
Branches 224 2939 +2715
==========================================
+ Hits 1358 9232 +7874
- Misses 65 328 +263
- Partials 64 279 +215
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | patch | [`5.27.0` -> `5.27.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.27.0/5.27.1) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | patch | [`5.27.0` -> `5.27.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.27.0/5.27.1) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v5.27.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5271-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5270v5271-2022-06-06) [Compare Source](typescript-eslint/typescript-eslint@v5.27.0...v5.27.1) ##### Bug Fixes - **eslint-plugin:** \[space-infix-ops] correct PropertyDefinition with typeAnnotation ([#​5113](typescript-eslint/typescript-eslint#5113)) ([d320174](typescript-eslint/typescript-eslint@d320174)) - **eslint-plugin:** \[space-infix-ops] regression fix for conditional types ([#​5135](typescript-eslint/typescript-eslint#5135)) ([e5238c8](typescript-eslint/typescript-eslint@e5238c8)) - **eslint-plugin:** \[space-infix-ops] regression fix for type aliases ([#​5138](typescript-eslint/typescript-eslint#5138)) ([4e13deb](typescript-eslint/typescript-eslint@4e13deb)) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v5.27.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5271-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5270v5271-2022-06-06) [Compare Source](typescript-eslint/typescript-eslint@v5.27.0...v5.27.1) **Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1399 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.27.1` -> `5.28.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.27.1/5.28.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.27.1` -> `5.28.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.27.1/5.28.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v5.28.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5280-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5271v5280-2022-06-13) [Compare Source](typescript-eslint/typescript-eslint@v5.27.1...v5.28.0) ##### Bug Fixes - \[TS4.7] allow visiting of typeParameters in TSTypeQuery ([#​5166](typescript-eslint/typescript-eslint#5166)) ([dc1f930](typescript-eslint/typescript-eslint@dc1f930)) - **eslint-plugin:** \[space-infix-ops] support for optional property without type ([#​5155](typescript-eslint/typescript-eslint#5155)) ([1f25daf](typescript-eslint/typescript-eslint@1f25daf)) ##### Features - **eslint-plugin:** \[consistent-generic-constructors] add rule ([#​4924](typescript-eslint/typescript-eslint#4924)) ([921cdf1](typescript-eslint/typescript-eslint@921cdf1)) #### [5.27.1](typescript-eslint/typescript-eslint@v5.27.0...v5.27.1) (2022-06-06) ##### Bug Fixes - **eslint-plugin:** \[space-infix-ops] correct PropertyDefinition with typeAnnotation ([#​5113](typescript-eslint/typescript-eslint#5113)) ([d320174](typescript-eslint/typescript-eslint@d320174)) - **eslint-plugin:** \[space-infix-ops] regression fix for conditional types ([#​5135](typescript-eslint/typescript-eslint#5135)) ([e5238c8](typescript-eslint/typescript-eslint@e5238c8)) - **eslint-plugin:** \[space-infix-ops] regression fix for type aliases ([#​5138](typescript-eslint/typescript-eslint#5138)) ([4e13deb](typescript-eslint/typescript-eslint@4e13deb)) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v5.28.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5280-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5271v5280-2022-06-13) [Compare Source](typescript-eslint/typescript-eslint@v5.27.1...v5.28.0) **Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) #### [5.27.1](typescript-eslint/typescript-eslint@v5.27.0...v5.27.1) (2022-06-06) **Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1409 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
PR Checklist
Overview
Additional regression fix for #5041
/^[=|?|:]$/.test(token.value)