feat(eslint-plugin): [no-shadow] add shadowed variable location to the error message

[bradzacher]

PR Checklist

• Steps in CONTRIBUTING.md were taken

Overview

I noticed that we had missed eslint/eslint#13841. This is a pretty valuable upstream change which greatly improves the error message.

Whilst I was here I also followed the same test structure for no-unused-vars where we separate the tests from upstream eslint into a separate file from our local tests.
I did this now because I noticed that someone had added tests for our logic to the "eslint tests" section - so when I pasted the upstream tests I deleted a bunch of tests!
It shouldn't be an issue in future.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a58c221. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 47 targets

• Node 18 - nx test @typescript-eslint/eslint-plugin
• Node 12 - nx test @typescript-eslint/eslint-plugin --coverage=false
• nx run-many --target=build --all --parallel --exclude website
• Node 18 - nx test @typescript-eslint/visitor-keys
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/type-utils
• Node 18 - nx test @typescript-eslint/typescript-estree
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=typecheck --all --parallel
• Node 12 - nx test @typescript-eslint/typescript-estree --coverage=false
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/scope-manager --coverage=false
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/parser --coverage=false
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/eslint-plugin-tslint --coverage=false
• Node 18 - nx test @typescript-eslint/eslint-plugin-tslint
• Node 18 - nx test @typescript-eslint/eslint-plugin-internal
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/visitor-keys --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/parser
• Node 12 - nx test @typescript-eslint/utils --coverage=false
• Node 18 - nx test @typescript-eslint/scope-manager
• Node 18 - nx test @typescript-eslint/utils
• Node 12 - nx test @typescript-eslint/type-utils --coverage=false
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/ast-spec --coverage=false
• Node 18 - nx test @typescript-eslint/ast-spec
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/eslint-plugin-internal --coverage=false
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[typescript-eslint]

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	a58c221
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/62b8b9ec3eac3f00097e87dd
😎 Deploy Preview	https://deploy-preview-5183--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[codecov]

Codecov Report

Merging #5183 (a58c221) into main (2600f7f) will increase coverage by 2.43%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5183      +/-   ##
==========================================
+ Coverage   91.33%   93.76%   +2.43%     
==========================================
  Files         132      287     +155     
  Lines        1488     9868    +8380     
  Branches      224     2952    +2728     
==========================================
+ Hits         1359     9253    +7894     
- Misses         65      335     +270     
- Partials       64      280     +216     

Flag	Coverage Δ
unittest	93.76% <100.00%> (+2.43%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/no-shadow.ts	75.84% <100.00%> (ø)
...plugin/src/rules/naming-convention-utils/shared.ts	100.00% <0.00%> (ø)
...rc/rules/indent-new-do-not-use/BinarySearchTree.ts	100.00% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/no-for-in-array.ts	100.00% <0.00%> (ø)
...slint-plugin/src/rules/no-unnecessary-condition.ts	98.30% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/no-invalid-this.ts	80.00% <0.00%> (ø)
.../eslint-plugin/src/rules/promise-function-async.ts	98.03% <0.00%> (ø)
.../src/rules/sort-type-union-intersection-members.ts	90.74% <0.00%> (ø)
packages/eslint-plugin/src/rules/unbound-method.ts	92.13% <0.00%> (ø)
...src/rules/naming-convention-utils/parse-options.ts	100.00% <0.00%> (ø)
... and 146 more

[JoshuaKGoldberg]

Super, thank you!

[JoshuaKGoldberg]

Nitty nit: could be simplified to return identifier ? { ... } : { ... };.

[bradzacher]

you really do love your ternaries 😄
personally I prefer to only use ternaries for when I want an expression.
I find in this case where I can do everything with statements - using an if statement is clearer and cleaner.