fix(eslint-plugin): [no-inferrable] fix optional param to valid code

[Josh-Cena]

PR Checklist

• Addresses an existing open issue: fixes Bug: no-inferrable-types fixer does not remove ? when removing the type #5340
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

(I have a feeling we need more test cases, but I can't think of any edge-cases.)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7598abb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 47 targets

• Node 18 - nx test @typescript-eslint/eslint-plugin
• Node 12 - nx test @typescript-eslint/eslint-plugin --coverage=false
• nx run-many --target=build --all --parallel --exclude website
• Node 18 - nx test @typescript-eslint/type-utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/utils
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=typecheck --all --parallel
• Node 18 - nx test @typescript-eslint/visitor-keys
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/typescript-estree
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/ast-spec
• Node 18 - nx test @typescript-eslint/eslint-plugin-tslint
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/eslint-plugin-internal
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/type-utils --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/eslint-plugin-internal --coverage=false
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/visitor-keys --coverage=false
• Node 12 - nx test @typescript-eslint/parser --coverage=false
• Node 18 - nx test @typescript-eslint/scope-manager
• Node 12 - nx test @typescript-eslint/eslint-plugin-tslint --coverage=false
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/parser
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/scope-manager --coverage=false
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/ast-spec --coverage=false
• Node 12 - nx test @typescript-eslint/typescript-estree --coverage=false
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx test @typescript-eslint/utils --coverage=false
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[typescript-eslint]

Thanks for the PR, @Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	7598abb
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/62cf90e68d27480009027eaa
😎 Deploy Preview	https://deploy-preview-5342--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[codecov]

Codecov Report

Merging #5342 (7598abb) into main (75a86d9) will increase coverage by 2.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5342      +/-   ##
==========================================
+ Coverage   91.67%   93.77%   +2.09%     
==========================================
  Files         363      287      -76     
  Lines       12227     9875    -2352     
  Branches     3549     2956     -593     
==========================================
- Hits        11209     9260    -1949     
+ Misses        668      335     -333     
+ Partials      350      280      -70     

Flag	Coverage Δ
unittest	93.77% <100.00%> (+2.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ges/eslint-plugin/src/rules/no-inferrable-types.ts	95.00% <100.00%> (+0.35%)	⬆️
packages/type-utils/src/getTokenAtPosition.ts
packages/type-utils/src/containsAllTypesByName.ts
...ges/type-utils/src/getConstrainedTypeAtLocation.ts
...estree/src/create-program/createIsolatedProgram.ts
packages/type-utils/src/propertyTypes.ts
...ges/typescript-estree/src/create-program/shared.ts
packages/utils/src/ast-utils/eslint-utils/index.ts
...escript-estree/src/create-program/getScriptKind.ts
...escript-estree/src/semantic-or-syntactic-errors.ts
... and 67 more

[armano2]

not sure if we want to handle this in here, but there is one more use case that is broken.

playground

class Test {
  x!: number = 5
  abstract y!: number = 5
}

maybe something like this could be better:

if (
  node.type === AST_NODE_TYPES.AssignmentPattern &&
  node.left.optional
) {
  yield fixer.remove(sourceCode.getTokenBefore(typeNode)!);
} else if (
  (node.type === AST_NODE_TYPES.TSAbstractPropertyDefinition ||
  node.type === AST_NODE_TYPES.PropertyDefinition) &&
  node.definite
) {
  yield fixer.remove(sourceCode.getTokenBefore(typeNode)!);
}

we can make separate ticket for this, if you like

---

there is also

class Test2 {
  constructor(private a: number = 5) { }
}

witch is currently not reported

[Josh-Cena]

I'll add definite assignment to this PR, but the private one seems tangential to this. Does this one also seem worth reporting?

class Test2 {
  x?: number = 5;
}

[Josh-Cena]

Also, the abstract y!: number = 5 is too messed up to be autofixed. The initializer needs to be removed as well. It isn't even reported by the rule under the status quo, so I'll just ignore that.

[bradzacher]

thanks for fixing this!