Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [explicit-module-boundary-types] remove shouldTrackReferences option from schema #5399

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jul 29, 2022

BREAKING CHANGE:
Removes an option from a rule's schema

PR Checklist

Overview

Quick little breaking change to the options schema. It's not used anywhere.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Jul 29, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 493b91e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg added the breaking change This change will require a new major version to be released label Jul 29, 2022
@netlify
Copy link

netlify bot commented Jul 29, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 493b91e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/635838801b301a00097130c1
😎 Deploy Preview https://deploy-preview-5399--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bradzacher bradzacher added this to the 6.0.0 milestone Jul 29, 2022
@JoshuaKGoldberg JoshuaKGoldberg changed the base branch from main to v6 October 25, 2022 21:10
@bradzacher bradzacher added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label Oct 26, 2022
@JoshuaKGoldberg JoshuaKGoldberg merged commit 5b9c379 into typescript-eslint:v6 Oct 26, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the remove-should-track-references branch October 26, 2022 15:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready breaking change This change will require a new major version to be released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: [explicit-module-boundary-types] Remove shouldTrackReferences
2 participants