fix(eslint-plugin): [strict-boolean-expressions] check all conditions in a logical operator chain

[phaux]

PR Checklist

• Addresses an existing open issue: fixes Bug: [strict-boolean-expressions] Only the first operand in a chain of && is checked #5518
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

At first it was a one line change but then I also refactored the recursive code to make it more easy to reason about hopefully.

Before:

checked && skipped && skipped && skipped;

After:

checked && checked && checked && skipped;

Same for ||

[typescript-eslint]

Thanks for the PR, @phaux!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5ee55fe. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 25 targets

• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/ast-spec --coverage=false
• Node 14 - nx test @typescript-eslint/eslint-plugin --coverage=false
• Node 14 - nx test @typescript-eslint/eslint-plugin-internal --coverage=false
• Node 14 - nx test @typescript-eslint/eslint-plugin-tslint --coverage=false
• Node 14 - nx test @typescript-eslint/parser --coverage=false
• Node 14 - nx test @typescript-eslint/scope-manager --coverage=false
• Node 14 - nx test @typescript-eslint/type-utils --coverage=false
• Node 14 - nx test @typescript-eslint/typescript-estree --coverage=false
• Node 14 - nx test @typescript-eslint/utils --coverage=false
• Node 14 - nx test @typescript-eslint/visitor-keys --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/ast-spec
• Node 18 - nx test @typescript-eslint/eslint-plugin
• Node 18 - nx test @typescript-eslint/eslint-plugin-internal
• Node 18 - nx test @typescript-eslint/eslint-plugin-tslint
• Node 18 - nx test @typescript-eslint/parser
• Node 18 - nx test @typescript-eslint/scope-manager
• Node 18 - nx test @typescript-eslint/type-utils
• Node 18 - nx test @typescript-eslint/typescript-estree
• Node 18 - nx test @typescript-eslint/utils
• Node 18 - nx test @typescript-eslint/visitor-keys
• nx run-many --target=build --all --parallel --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=typecheck --all --parallel

---

Sent with 💌 from NxCloud.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	5ee55fe
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6319f297d9e95f00084fbc69
😎 Deploy Preview	https://deploy-preview-5539--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[codecov]

Codecov Report

Merging #5539 (5ee55fe) into main (8176fb1) will increase coverage by 2.17%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5539      +/-   ##
==========================================
+ Coverage   91.63%   93.80%   +2.17%     
==========================================
  Files         134      292     +158     
  Lines        1506    10009    +8503     
  Branches      226     3010    +2784     
==========================================
+ Hits         1380     9389    +8009     
- Misses         62      338     +276     
- Partials       64      282     +218     

Flag	Coverage Δ
unittest	93.80% <100.00%> (+2.17%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...int-plugin/src/rules/strict-boolean-expressions.ts	98.83% <100.00%> (ø)
packages/eslint-plugin/src/rules/no-type-alias.ts	100.00% <0.00%> (ø)
...slint-plugin/src/rules/prefer-enum-initializers.ts	100.00% <0.00%> (ø)
...plugin/src/rules/naming-convention-utils/shared.ts	100.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-shadow.ts	75.84% <0.00%> (ø)
packages/eslint-plugin/src/util/isNullLiteral.ts	100.00% <0.00%> (ø)
...eslint-plugin/src/rules/no-parameter-properties.ts	94.11% <0.00%> (ø)
...kages/eslint-plugin/src/rules/no-empty-function.ts	79.48% <0.00%> (ø)
...rc/rules/indent-new-do-not-use/BinarySearchTree.ts	100.00% <0.00%> (ø)
...ckages/eslint-plugin/src/util/getESLintCoreRule.ts	75.00% <0.00%> (ø)
... and 149 more

[JoshuaKGoldberg]

Could you add some passing (valid) test cases too, please?

[JoshuaKGoldberg]

This looks great, +1 to the refactor!

Just requesting changes on a little bit more testing please.

[JoshuaKGoldberg]

💯, thanks @phaux!