Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typedef] What is ETA of the typedef rule? #558

Closed
takuma7 opened this issue May 27, 2019 · 3 comments · Fixed by #581
Closed

[typedef] What is ETA of the typedef rule? #558

takuma7 opened this issue May 27, 2019 · 3 comments · Fixed by #581
Labels
enhancement: new plugin rule New rule request for eslint-plugin has pr there is a PR raised to close this package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@takuma7
Copy link

takuma7 commented May 27, 2019

I'm thinking of migrating from TSLint to ESLint. Reading the roadmap, I realized the typedef rule is still "unimplemented".

Is there any plan to implement this rule? If yes, do we have any ETA?

Thank you!

@takuma7 takuma7 added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels May 27, 2019
@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label May 28, 2019
@bradzacher
Copy link
Member

bradzacher commented May 28, 2019

If I'm understanding that rule, then it looks like it can be "implemented" as follows:

  • turn on noImplicitAny in your tsconfig.
  • turn on our rule @typescript-eslint/explicit-function-return-type.

There are a two options not covered by the above though: object-destructuring and array-destructuring.
Happy for someone to add those in if they want, but I see those as a low value additions - it's a type pattern that i've never actually seen used before.

gruckion added a commit to NewOrbit/eslint-config that referenced this issue May 29, 2019
@gruckion
Copy link

@bradzacher a follow up to the above reference, we are using the suggested and it appears to cover our use case.

@bradzacher bradzacher added enhancement: new plugin rule New rule request for eslint-plugin has pr there is a PR raised to close this and removed awaiting response Issues waiting for a reply from the OP or another party triage Waiting for maintainers to take a look labels Jun 11, 2019
@bradzacher
Copy link
Member

As an FYI there is an open PR to add the typedef rule (#581).
It is under discussion though.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: new plugin rule New rule request for eslint-plugin has pr there is a PR raised to close this package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants