feat(eslint-plugin): allow using void as a default type for a generic argument if allowInGenericTypeArguments is specified

[kazizi55]

PR Checklist

• Addresses an existing open issue: fixes Bug: [no-invalid-void-type] Does not allow using void as a default type for a generic argument #5644
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

• allows using void as a default type for a generic argument if allowInGenericTypeArguments is specified

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 508ab8f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 47 targets

• Node 18 - nx test @typescript-eslint/eslint-plugin
• Node 14 - nx test @typescript-eslint/eslint-plugin --coverage=false
• nx run-many --target=build --all --parallel --exclude website
• Node 18 - nx test @typescript-eslint/utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/type-utils
• Node 18 - nx test @typescript-eslint/visitor-keys
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=typecheck --all --parallel
• Node 18 - nx test @typescript-eslint/scope-manager
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/parser
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/typescript-estree --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/parser --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/ast-spec
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/scope-manager --coverage=false
• Node 14 - nx test @typescript-eslint/ast-spec --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/eslint-plugin-internal
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/visitor-keys --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/typescript-estree
• Node 14 - nx test @typescript-eslint/utils --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/eslint-plugin-tslint --coverage=false
• Node 18 - nx test @typescript-eslint/eslint-plugin-tslint
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/type-utils --coverage=false
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/eslint-plugin-internal --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[typescript-eslint]

Thanks for the PR, @kazizi55!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	508ab8f
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63390e6b137f95000950c686
😎 Deploy Preview	https://deploy-preview-5671--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[codecov]

Codecov Report

Merging #5671 (508ab8f) into main (5adf7bd) will increase coverage by 2.93%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5671      +/-   ##
==========================================
+ Coverage   91.01%   93.94%   +2.93%     
==========================================
  Files         365      288      -77     
  Lines       11962     9582    -2380     
  Branches     3483     2884     -599     
==========================================
- Hits        10887     9002    -1885     
+ Misses        781      333     -448     
+ Partials      294      247      -47     

Flag	Coverage Δ
unittest	93.94% <100.00%> (+2.93%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...es/eslint-plugin/src/rules/no-invalid-void-type.ts	95.83% <100.00%> (+0.71%)	⬆️
packages/utils/src/ts-eslint-scope/Referencer.ts
packages/typescript-estree/src/convert.ts
packages/utils/src/eslint-utils/RuleCreator.ts
...plugin-internal/src/rules/prefer-ast-types-enum.ts
packages/typescript-estree/src/convert-comments.ts
packages/typescript-estree/src/ts-estree/index.ts
packages/type-utils/src/getTokenAtPosition.ts
packages/utils/src/ts-eslint-scope/ScopeManager.ts
packages/utils/src/eslint-utils/RuleTester.ts
... and 68 more

[JoshuaKGoldberg]

The code looks good at first glance, but there's an odd bug in the edge cases. I can take a closer look once that's fixed. Thanks!

Changes

[JoshuaKGoldberg]

Getting closer, thanks! The tests all look good but the source code confused me a bit. I think we can simplify it to be more clear.

[JoshuaKGoldberg]

Super, thanks for sending this in & iterating @kazizi55! 🙌