fix(eslint-plugin): [no-type-alias] Fix parenthesized type handling #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
==========================================
- Coverage 94.29% 94.25% -0.05%
==========================================
Files 104 104
Lines 4244 4245 +1
Branches 1158 1157 -1
==========================================
- Hits 4002 4001 -1
- Misses 141 142 +1
- Partials 101 102 +1
|
JamesHenry
approved these changes
Jun 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #575
It was going to be annoying to insert
ifs all over the place so I refactored the logic to make it cleaner.