feat(scope-manager): ignore ECMA version

[JoshuaKGoldberg]

BREAKING CHANGE:
Removes part of the public API for the parser and scope-manager.

PR Checklist

• Addresses an existing open issue: fixes [scope-manager] should ignore parserOptions.ecmaVersion #2900
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Per the issue, ignores ecmaVersion in the options, and assumes it's always ESNext.

[typescript-eslint]

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 04e8bed. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 46 targets

• Node 18 - nx test @typescript-eslint/eslint-plugin
• Node 14 - nx test @typescript-eslint/eslint-plugin --coverage=false
• nx run-many --target=typecheck --all --parallel
• nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/visitor-keys
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/scope-manager
• Node 18 - nx test @typescript-eslint/parser
• Node 14 - nx test @typescript-eslint/scope-manager --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/eslint-plugin-tslint
• Node 18 - nx test @typescript-eslint/utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/type-utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/eslint-plugin-tslint --coverage=false
• Node 14 - nx test @typescript-eslint/type-utils --coverage=false
• Node 14 - nx test @typescript-eslint/parser --coverage=false
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/eslint-plugin-internal --coverage=false
• Node 18 - nx test @typescript-eslint/eslint-plugin-internal
• Node 14 - nx test @typescript-eslint/visitor-keys --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/utils --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/typescript-estree --coverage=false
• Node 18 - nx test @typescript-eslint/typescript-estree
• Node 18 - nx test @typescript-eslint/ast-spec
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/ast-spec --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	04e8bed
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63589dbb2fad4500083a4ef6
😎 Deploy Preview	https://deploy-preview-5881--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[codecov]

Codecov Report

Merging #5881 (70e73fb) into main (2019c2f) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

❗ Current head 70e73fb differs from pull request most recent head 04e8bed. Consider uploading reports for the commit 04e8bed to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5881      +/-   ##
==========================================
- Coverage   91.36%   91.34%   -0.02%     
==========================================
  Files         364      364              
  Lines       12134    12123      -11     
  Branches     3540     3530      -10     
==========================================
- Hits        11086    11074      -12     
- Misses        748      750       +2     
+ Partials      300      299       -1     

Flag	Coverage Δ
unittest	91.34% <57.14%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/scope-manager/src/ScopeManager.ts	77.21% <0.00%> (-2.54%)	⬇️
packages/scope-manager/src/analyze.ts	57.89% <0.00%> (-7.49%)	⬇️
...ackages/scope-manager/src/referencer/Referencer.ts	95.90% <100.00%> (-0.07%)	⬇️

[bradzacher]

we can also remove the code from higher up the chain!

start from here and work your way down!
https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/src/parser.ts#L108

[bradzacher]

Hmmm. I wonder if maybe I was too over-zealous with my recommendation to cull higher?

Having this auto-resolved is a really nice property. For the most part it shouldn't cause any issues for people (it just includes a few more global variables for people using rules like no-undef or no-use-before-define), but there might be edge cases?

Hmm. WDYT? I'm torn on if it's worth the code.

[JoshuaKGoldberg]

Neither of those are rules we recommend folks use - and folks should generally always be in >=ES2021 or so these days. I say let's kill them for now, and use the RC period to see if anybody notices! 🔪

[JoshuaKGoldberg]

Oh I will mark this as a breaking change now though.

[JoshuaKGoldberg]

AGH the branch change to v6 didn't go through. 🤦