Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum supported TS version to 4.2 to match DefinitelyTyped's 2y version support window #5914

Closed
bradzacher opened this issue Nov 2, 2022 · 2 comments
Closed

Bump minimum supported TS version to 4.2 to match DefinitelyTyped's 2y version support window #5914

bradzacher opened this issue Nov 2, 2022 · 2 comments
Assignees
@bradzacher
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released dependencies Issue about dependencies of the package
Milestone
6.0.0

Comments

@bradzacher
Copy link
Member

Suggestion

Reference: #1752 (comment)

DefinitelyTyped only tests against and guarantees support for versions up to 2 years old - https://github.com/DefinitelyTyped/DefinitelyTyped#support-window

We talked about this a while ago but never got around to it - let's bump the minimum version in the next major.

This will allow us to delete a bunch of branches from our codebase reducing complexity and maintenance burden.
@bradzacher bradzacher added breaking change This change will require a new major version to be released dependencies Issue about dependencies of the package accepting prs Go ahead, send a pull request that resolves this issue labels Nov 2, 2022
@bradzacher bradzacher added this to the 6.0.0 milestone Nov 2, 2022
@bradzacher bradzacher self-assigned this Nov 2, 2022
@bradzacher bradzacher mentioned this issue Nov 2, 2022
Merged
3 tasks
@JoshuaKGoldberg
Copy link
Member

Would be good to add this to the upcoming maintenance guide too! #5238

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Nov 6, 2022
Closed
2 tasks
@JoshuaKGoldberg
Copy link
Member

#5915 is merged into #5886; closing this issue now accordingly. It'll be released as a part of the v6 major release.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bradzacher bradzacher

Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released dependencies Issue about dependencies of the package
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
2 participants
@JoshuaKGoldberg @bradzacher