Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typescript-estree): allow expressions in ExportDefaultDeclaration #593

Merged
merged 1 commit into from Jun 6, 2019
Merged

fix(typescript-estree): allow expressions in ExportDefaultDeclaration #593

merged 1 commit into from Jun 6, 2019

Conversation

nevir
Copy link
Contributor

@nevir nevir commented Jun 5, 2019 •
edited

Currently ExportDefaultDeclaration is locked down to only ExportDeclaration, but expressions are also valid. For example:

export default new Foo();
export default 123;
export default bar;

@nevir nevir changed the title fix(typescript-estree): Fix ExportDefaultDeclaration to support all declarations and expressions fix(typescript-estree): Fix ExportDefaultDeclaration to allow expressions Jun 5, 2019
@nevir nevir changed the title fix(typescript-estree): Fix ExportDefaultDeclaration to allow expressions fix(typescript-estree): allow expressions in ExportDefaultDeclaration Jun 5, 2019
@bradzacher bradzacher merged commit 861844d into typescript-eslint:master Jun 6, 2019
@nevir nevir deleted the patch-1 branch June 6, 2019 17:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nevir @bradzacher