Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [no-floating-promises] add suggestion fixer to add an 'await' #5943

Merged
merged 13 commits into from Dec 16, 2022

Conversation

sena-anny
Copy link
Contributor

PR Checklist

Overview

Add suggestion fixer to add an 'await'

@nx-cloud
Copy link

nx-cloud bot commented Nov 8, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7bf32b6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sena-anny!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Nov 8, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7bf32b6
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6399c03b4915db0008e06b69
😎 Deploy Preview https://deploy-preview-5943--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #5943 (7bf32b6) into main (3ce2549) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5943      +/-   ##
==========================================
+ Coverage   91.27%   91.28%   +0.01%     
==========================================
  Files         366      366              
  Lines       12433    12445      +12     
  Branches     3641     3645       +4     
==========================================
+ Hits        11348    11361      +13     
+ Misses        774      773       -1     
  Partials      311      311              
Flag Coverage Δ
unittest 91.28% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/eslint-plugin/src/rules/no-floating-promises.ts 100.00% <100.00%> (ø)
...es/eslint-plugin/src/util/getOperatorPrecedence.ts 42.85% <0.00%> (+2.85%) ⬆️

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start, thanks for sending this in @sena-anny! 🙌

Requesting changes on a bit more test coverage, and reducing the area replaced.

packages/eslint-plugin/src/rules/no-floating-promises.ts Outdated Show resolved Hide resolved
packages/eslint-plugin/src/rules/no-floating-promises.ts Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Nov 13, 2022
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close! 🙌

@bradzacher bradzacher changed the title fix(eslint-plugin):[no-floating-promises] Add suggestion fixer to add an 'await' feat(eslint-plugin):[no-floating-promises] Add suggestion fixer to add an 'await' Nov 16, 2022
@bradzacher bradzacher added the enhancement New feature or request label Nov 16, 2022
@sena-anny sena-anny requested review from JoshuaKGoldberg and bradzacher and removed request for JoshuaKGoldberg and bradzacher November 18, 2022 16:27
@bradzacher bradzacher changed the title feat(eslint-plugin):[no-floating-promises] Add suggestion fixer to add an 'await' feat(eslint-plugin): [no-floating-promises] Add suggestion fixer to add an 'await' Nov 24, 2022
@bradzacher bradzacher changed the title feat(eslint-plugin): [no-floating-promises] Add suggestion fixer to add an 'await' feat(eslint-plugin): [no-floating-promises] add suggestion fixer to add an 'await' Nov 24, 2022
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Nov 24, 2022
@JoshuaKGoldberg JoshuaKGoldberg dismissed their stale review November 27, 2022 15:28

Will defer to bradzacher's review :)

@sena-anny
Copy link
Contributor Author

@bradzacher
Could you check this PR?

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the precedence fixes, this LGTM!
Thanks for adding a fixer!

@bradzacher bradzacher merged commit 9e35ef9 into typescript-eslint:main Dec 16, 2022
omril1 pushed a commit to omril1/typescript-eslint that referenced this pull request Dec 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: [no-floating-promises] Add suggestion fixer to add an 'await'
3 participants