Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin)!: Move opinionated rules from 'eslint-recommended' to 'recommended' #595

Merged
merged 2 commits into from Jul 24, 2019
Merged

feat(eslint-plugin)!: Move opinionated rules from 'eslint-recommended' to 'recommended' #595

merged 2 commits into from Jul 24, 2019

Conversation

borekb
Copy link
Contributor

@borekb borekb commented Jun 6, 2019 •
edited by bradzacher

BREAKING CHANGE

Resolves #592.

@borekb
feat(eslint-plugin): move opinionated rules between configs
5ffdb6b 
BREAKING CHANGE: both 'eslint-recommended' and 'recommended' have changed.
@bradzacher bradzacher added breaking change This change will require a new major version to be released recommended-rules Discussion about recommended rule sets labels Jun 6, 2019
@bradzacher bradzacher mentioned this pull request Jun 28, 2019
Closed
14 tasks
@bradzacher bradzacher added this to the 2.0.0 milestone Jun 28, 2019
@bradzacher bradzacher mentioned this pull request Jun 29, 2019
Closed
@bradzacher bradzacher changed the title Move opinionated rules from 'eslint-recommended' to 'recommended' feat(eslint-plugin)!: Move opinionated rules from 'eslint-recommended' to 'recommended' Jul 21, 2019
JamesHenry
JamesHenry approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks

@JamesHenry JamesHenry added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label Jul 24, 2019
@JamesHenry JamesHenry merged commit 4893aec into typescript-eslint:master Jul 24, 2019
bradzacher added a commit that referenced this pull request Jul 29, 2019
@bradzacher
fix: add generation for rules added in #595
bf4ae8a
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready breaking change This change will require a new major version to be released recommended-rules Discussion about recommended rule sets
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Move opinionated rules from 'eslint-recommended' to 'recommended'?
3 participants
@borekb @JamesHenry @bradzacher