Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): stop ignoring comments in JSX with generic #596

Merged
merged 2 commits into from Jun 7, 2019

Conversation

duailibe
Copy link
Contributor

@duailibe duailibe commented Jun 6, 2019

Resolves #583

Prevent ignoring comments in JSX tags with generics

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bradzacher bradzacher merged commit 31d5bd4 into typescript-eslint:master Jun 7, 2019
@duailibe duailibe deleted the jsx-with-generics branch June 7, 2019 12:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignores comment after generic JsxOpeningElement
3 participants