New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [keyword-spacing] Support spacing in import-type syntax #5977
feat(eslint-plugin): [keyword-spacing] Support spacing in import-type syntax #5977
Conversation
Thanks for the PR, @omril1! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5977 +/- ##
=======================================
Coverage 91.41% 91.42%
=======================================
Files 365 365
Lines 12328 12337 +9
Branches 3607 3609 +2
=======================================
+ Hits 11270 11279 +9
Misses 753 753
Partials 305 305
Flags with carried forward coverage won't be shown. Click here to find out more.
|
keyword-spacing
- Support spacing in import-type
syntax
keyword-spacing
- Support spacing in import-type
syntaxThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for sending this in @omril1! ✨
PR Checklist
import type
#5362Overview
Add a space between
type
token and*
or{
tokens whenafter
option is true, and remove whenafter
is false