New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [strict-boolean-expressions] add allow nullable enum to strict boolean expressions #6096
Conversation
Thanks for the PR, @kazizi55! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6096 +/- ##
=======================================
Coverage 91.52% 91.53%
=======================================
Files 371 371
Lines 12651 12662 +11
Branches 3717 3721 +4
=======================================
+ Hits 11579 11590 +11
Misses 754 754
Partials 318 318
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far, thanks! Requesting changes on simplifying the code a bit, splitting up tests, and adding docs. ✨
packages/eslint-plugin/tests/rules/strict-boolean-expressions.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
…test.ts Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking excellent! ✨
Just the two small cleanups about comments and simplifying the types filtering. I'm happy to do those soon if you don't want to keep adjusting for my pestering 😄 - up to you.
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Progress! 🚀
packages/eslint-plugin/docs/rules/strict-boolean-expressions.md
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/docs/rules/strict-boolean-expressions.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Need to address the lint failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for iterating on it with us! 🙌
The lint failure was a single test case so I just went ahead and fixed it. 🚢
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.50.0` -> `5.51.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.50.0/5.51.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.50.0` -> `5.51.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.50.0/5.51.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v5.51.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5510-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5500v5510-2023-02-06) [Compare Source](typescript-eslint/typescript-eslint@v5.50.0...v5.51.0) ##### Bug Fixes - **eslint-plugin:** \[sort-type-constituents] fixed behavior change ([#​6384](typescript-eslint/typescript-eslint#6384)) ([5bf7f7f](typescript-eslint/typescript-eslint@5bf7f7f)), closes [#​6339](typescript-eslint/typescript-eslint#6339) - **eslint-plugin:** do not use .at(), Node 14 does not support it ([#​6402](typescript-eslint/typescript-eslint#6402)) ([077ed1b](typescript-eslint/typescript-eslint@077ed1b)) ##### Features - **eslint-plugin:** \[naming-convention] improve performance by removing unnecessary selectors ([#​6376](typescript-eslint/typescript-eslint#6376)) ([3647a1c](typescript-eslint/typescript-eslint@3647a1c)) - **eslint-plugin:** \[no-floating-promises] error on logical expression ([#​6356](typescript-eslint/typescript-eslint#6356)) ([f330e06](typescript-eslint/typescript-eslint@f330e06)) - **eslint-plugin:** \[no-import-type-side-effects] add rule to warn against runtime side effects with `verbatimModuleSyntax` ([#​6394](typescript-eslint/typescript-eslint#6394)) ([b14d3be](typescript-eslint/typescript-eslint@b14d3be)) - **eslint-plugin:** \[strict-boolean-expressions] add allow nullable enum to strict boolean expressions ([#​6096](typescript-eslint/typescript-eslint#6096)) ([d4747cd](typescript-eslint/typescript-eslint@d4747cd)) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v5.51.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5510-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5500v5510-2023-02-06) [Compare Source](typescript-eslint/typescript-eslint@v5.50.0...v5.51.0) **Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMjQuMyIsInVwZGF0ZWRJblZlciI6IjM0LjEyOC4zIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1773 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
PR Checklist
Overview
Adds a new rule
allowNullableEnum
, in order to catch potential issues where one of the valid values of the Enum is falsy.