feat(eslint-plugin): [no-unsafe-enum-comparison] add rule

[JoshuaKGoldberg]

PR Checklist

• Addresses an existing open issue: half of Rule proposal: Disallow literals where enums are expected #308
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Adds the no-unsafe-enum-comparison rule to prevent comparing enum values against literals.

Extracted from #6091.

Co-authored-by: @Zamiell

[typescript-eslint]

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 68ad65c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 47 targets

• Node 18 - nx test eslint-plugin
• Node 14 - nx test eslint-plugin --coverage=false
• Node 18 - nx test typescript-estree
• Node 18 - nx test type-utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test parser
• Node 18 - nx test utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test visitor-keys
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test scope-manager
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=lint --all --parallel
• nx run-many --target=typecheck --all --parallel
• Node 18 - nx test eslint-plugin-internal
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test eslint-plugin-internal --coverage=false
• Node 14 - nx test utils --coverage=false
• Node 18 - nx test ast-spec
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test eslint-plugin-tslint
• Node 14 - nx test type-utils --coverage=false
• Node 14 - nx test typescript-estree --coverage=false
• Node 14 - nx test visitor-keys --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test ast-spec --coverage=false
• Node 14 - nx test eslint-plugin-tslint --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test parser --coverage=false
• Node 14 - nx test scope-manager --coverage=false
• nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	b1c9bec
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/642dc3851bc43d0007bdce5f
😎 Deploy Preview	https://deploy-preview-6107--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[codecov]

Codecov Report

Merging #6107 (b1c9bec) into main (75806c9) will increase coverage by 0.02%.
The diff coverage is 93.18%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6107      +/-   ##
==========================================
+ Coverage   87.34%   87.36%   +0.02%     
==========================================
  Files         384      386       +2     
  Lines       13147    13190      +43     
  Branches     3858     3867       +9     
==========================================
+ Hits        11483    11524      +41     
- Misses       1298     1300       +2     
  Partials      366      366              

Flag	Coverage Δ
unittest	87.36% <93.18%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/type-utils/src/typeFlagUtils.ts	76.92% <50.00%> (+1.92%)	⬆️
...kages/eslint-plugin/src/rules/enum-utils/shared.ts	81.81% <81.81%> (ø)
...lint-plugin/src/rules/no-unsafe-enum-comparison.ts	100.00% <100.00%> (ø)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b1c9bec. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 25 targets

• Node 14 - nx test eslint-plugin --coverage=false
• Node 18 - nx test eslint-plugin
• Node 18 - nx test utils
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test type-utils
• Node 18 - nx test visitor-keys
• nx run-many --target=typecheck --parallel
• Node 14 - nx test type-utils --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test utils --coverage=false
• nx run-many --target=lint --parallel
• Node 18 - nx test ast-spec
• nx run-many --target=build --parallel --exclude website
• Node 14 - nx test typescript-estree --coverage=false
• Node 14 - nx test visitor-keys --coverage=false
• Node 18 - nx test eslint-plugin-internal
• Node 14 - nx test parser --coverage=false
• Node 14 - nx test eslint-plugin-tslint --coverage=false
• Node 14 - nx test scope-manager --coverage=false
• Node 14 - nx test eslint-plugin-internal --coverage=false
• Node 18 - nx test typescript-estree
• Node 18 - nx test scope-manager
• Node 18 - nx test parser
• Node 14 - nx test ast-spec --coverage=false
• Node 18 - nx test eslint-plugin-tslint

---

Sent with 💌 from NxCloud.

[bradzacher]

changing the recommended configs is considered a breaking change

[JoshuaKGoldberg]

Oh shoot

[JoshuaKGoldberg]

Ah wait, per https://typescript-eslint.io/linting/configs, strict isn't considered stable. It's not in our "recommended" configs list. 😌

Still filing #6890 just in case.