Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): add simpleTraverse, replaces private ESLint util #628

Merged
merged 2 commits into from Jun 20, 2019

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented Jun 19, 2019

This should help avoid issues with ESLint 6 and any future prereleases when users start experimenting

Fixes #563

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #628 into master will decrease coverage by <.01%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
- Coverage   94.27%   94.27%   -0.01%     
==========================================
  Files         105      106       +1     
  Lines        4349     4365      +16     
  Branches     1197     1200       +3     
==========================================
+ Hits         4100     4115      +15     
  Misses        145      145              
- Partials      104      105       +1
Impacted Files Coverage Δ
packages/parser/src/parser.ts 100% <100%> (ø) ⬆️
packages/parser/src/simple-traverse.ts 95% <95%> (ø)
packages/typescript-estree/src/convert-comments.ts 96% <0%> (-0.3%) ⬇️

@JamesHenry JamesHenry merged commit aa206c4 into master Jun 20, 2019
@JamesHenry JamesHenry deleted the parser-simple-traverse branch June 20, 2019 01:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[parser] Error with ESLint 6.0.0 pre-releases
2 participants