feat(eslint-plugin): [no-floating-promises] error on logical expression #6356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @islandryu! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
islandryu
commented
Jan 20, 2023
| const myPromise = async () => void 0; | ||
| const condition = true; | ||
|
|
||
| void (condition && myPromise()); |
There was a problem hiding this comment.
The entire logical expression is enclosed in parentheses as in return-await.
https://typescript-eslint.io/play/#ts=4.9.3&sourceType=module&code=IYZwngdgxgBAZgV2gFwJYHsIwEbAE4AUAlDAN4wC+AsAFCiSyIoZZzrrFm0wzJ5hcaPHngCmyBHixIAJqLioIomTAA+qnPmIBubpRhRgyKAAsylWhSA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6aRfWaJ2gQwDufSvnRRE0aAHtokcGAC+IBUA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA
islandryu
changed the title
islandryu
changed the title
JoshuaKGoldberg
previously approved these changes
Jan 31, 2023
There was a problem hiding this comment.
LGTM, thanks! Just fix the build failure and 🚀 let's ship.
I was on the fence as to whether the suggestions should put the await/void immediately in front of the specific promise, rather than outside the logical expression (i.e. a || (await b) rather than await (a || b). But since it's just suggestions, not auto-fixing, I think this is fine to keep the rule simpler.
JoshuaKGoldberg
added
the
1 approval
bradzacher
added
the
awaiting response
…t-eslint into featNoFloatingPromisesLogicalExpressions
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6356 +/- ##
=======================================
Coverage 91.52% 91.52%
=======================================
Files 371 371
Lines 12649 12651 +2
Branches 3714 3717 +3
=======================================
+ Hits 11577 11579 +2
+ Misses 755 754 -1
- Partials 317 318 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
|
Build is cured! |
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Feb 10, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.50.0` -> `5.51.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.50.0/5.51.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.50.0` -> `5.51.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.50.0/5.51.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v5.51.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5510-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5500v5510-2023-02-06) [Compare Source](typescript-eslint/typescript-eslint@v5.50.0...v5.51.0) ##### Bug Fixes - **eslint-plugin:** \[sort-type-constituents] fixed behavior change ([#​6384](typescript-eslint/typescript-eslint#6384)) ([5bf7f7f](typescript-eslint/typescript-eslint@5bf7f7f)), closes [#​6339](typescript-eslint/typescript-eslint#6339) - **eslint-plugin:** do not use .at(), Node 14 does not support it ([#​6402](typescript-eslint/typescript-eslint#6402)) ([077ed1b](typescript-eslint/typescript-eslint@077ed1b)) ##### Features - **eslint-plugin:** \[naming-convention] improve performance by removing unnecessary selectors ([#​6376](typescript-eslint/typescript-eslint#6376)) ([3647a1c](typescript-eslint/typescript-eslint@3647a1c)) - **eslint-plugin:** \[no-floating-promises] error on logical expression ([#​6356](typescript-eslint/typescript-eslint#6356)) ([f330e06](typescript-eslint/typescript-eslint@f330e06)) - **eslint-plugin:** \[no-import-type-side-effects] add rule to warn against runtime side effects with `verbatimModuleSyntax` ([#​6394](typescript-eslint/typescript-eslint#6394)) ([b14d3be](typescript-eslint/typescript-eslint@b14d3be)) - **eslint-plugin:** \[strict-boolean-expressions] add allow nullable enum to strict boolean expressions ([#​6096](typescript-eslint/typescript-eslint#6096)) ([d4747cd](typescript-eslint/typescript-eslint@d4747cd)) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v5.51.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5510-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5500v5510-2023-02-06) [Compare Source](typescript-eslint/typescript-eslint@v5.50.0...v5.51.0) **Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMjQuMyIsInVwZGF0ZWRJblZlciI6IjM0LjEyOC4zIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1773 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
Promise in logical expression now also throws an error.