Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [sort-type-constituents] fixed behavior change #6384

Merged
merged 1 commit into from Jan 31, 2023

Conversation

sviat9440
Copy link
Contributor

@sviat9440 sviat9440 commented Jan 29, 2023

Fixed behavior change when sorting TSConditionalType (#6339)

PR Checklist

@nx-cloud
Copy link

nx-cloud bot commented Jan 29, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ea212dc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sviat9440!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jan 29, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ea212dc
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63d624f8b6db72000811493e
😎 Deploy Preview https://deploy-preview-6384--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sviat9440 sviat9440 changed the title fix(sort-type-constituents): Fixed behavior change fix(sort-type-constituents): Fixed behavior change #6339 Jan 29, 2023
@sviat9440 sviat9440 changed the title fix(sort-type-constituents): Fixed behavior change #6339 fix(sort-type-constituents): Fixed behavior change Jan 29, 2023
@sviat9440 sviat9440 changed the title fix(sort-type-constituents): Fixed behavior change fix(eslint-plugin): [sort-type-constituents] Fixed behavior change Jan 29, 2023
@sviat9440 sviat9440 changed the title fix(eslint-plugin): [sort-type-constituents] Fixed behavior change fix(eslint-plugin): [sort-type-constituents] fixed behavior change Jan 29, 2023
@bradzacher bradzacher added the bug Something isn't working label Jan 30, 2023
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯, perfect. Thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 5bf7f7f into typescript-eslint:main Jan 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [sort-type-constituents] Auto-fix can change behavior
3 participants