feat(eslint-plugin): [class-methods-use-this] add extension rule

[bradzacher]

PR Checklist

• Addresses an existing open issue: fixes [class-methods-use-this] Allow when required by interface #1103
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

This adds a standard AST fork of the base rule that can be configured to ignore one or both of the cases where a method has the override keyword, or the parent class implements an interface.

Based on #7260

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 71620da. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

🟥 Failed Commands
Node 18 - nx test eslint-plugin
Node 14 - nx test eslint-plugin --coverage=false

✅ Successfully ran 45 targets

• Node 18 - nx test utils
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test visitor-keys
• Node 14 - nx test typescript-estree --coverage=false
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test type-utils
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test typescript-estree
• Node 14 - nx test utils --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test ast-spec --coverage=false
• Node 14 - nx test type-utils --coverage=false
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test parser --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test visitor-keys --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test scope-manager --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test eslint-plugin-internal --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx run-many --target=build --parallel --exclude website
• Node 14 - nx test eslint-plugin-tslint --coverage=false
• Node 14 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=typecheck --parallel
• nx run-many --target=lint --parallel
• Node 18 - nx test scope-manager
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test parser
• Node 18 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• Node 18 - nx test eslint-plugin-internal
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx test ast-spec
• Node 18 - nx test eslint-plugin-tslint
• Node 18 - nx run-many --target=build --parallel --exclude website
• Node 18 - nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website
• nx run-many --target=build --parallel --exclude website

---

Sent with 💌 from NxCloud.

[typescript-eslint]

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	04b4d2c
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64b65f29f8c4f70009032a25
😎 Deploy Preview	https://deploy-preview-6457--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[JoshuaKGoldberg]

@bradzacher is this still something you have time to work on?

[bradzacher]

I think it was almost done if memory serves me correctly. I'll have a look today.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 41da796. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 35 targets

• nx test eslint-plugin --coverage=false
• Node 20 - nx test eslint-plugin
• Node 16 - nx test eslint-plugin --coverage=false
• Node 20 - nx test utils
• Node 20 - nx run types:build
• Node 20 - nx test type-utils
• Node 20 - nx test visitor-keys
• Node 20 - nx test typescript-estree
• Node 20 - nx test repo-tools
• Node 16 - nx test utils --coverage=false
• Node 20 - nx test rule-schema-to-typescript-types
• Node 16 - nx run types:build
• nx run-many --target=lint --parallel
• Node 20 - nx test scope-manager
• Node 20 - nx test parser
• Node 20 - nx test eslint-plugin-internal
• Node 20 - nx test eslint-plugin-tslint
• Node 20 - nx test ast-spec
• Node 16 - nx test type-utils --coverage=false
• Node 16 - nx test visitor-keys --coverage=false
• nx run-many --target=typecheck --parallel
• Node 16 - nx test eslint-plugin-tslint --coverage=false
• nx run types:build
• Node 16 - nx test typescript-estree --coverage=false
• nx run integration-tests:test
• Node 16 - nx test repo-tools --coverage=false
• Node 16 - nx test ast-spec --coverage=false
• Node 16 - nx test parser --coverage=false
• Node 16 - nx test rule-schema-to-typescript-types --coverage=false
• Node 16 - nx test eslint-plugin-internal --coverage=false
• Node 16 - nx test scope-manager --coverage=false
• nx test eslint-plugin-tslint --coverage=false
• nx test typescript-estree --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Merging #6457 (41da796) into update-getFunctionHeadLoc (be95293) will decrease coverage by 0.09%.
The diff coverage is 69.35%.

Additional details and impacted files

@@                      Coverage Diff                      @@
##           update-getFunctionHeadLoc    #6457      +/-   ##
=============================================================
- Coverage                      87.48%   87.40%   -0.09%     
=============================================================
  Files                            379      381       +2     
  Lines                          13250    13311      +61     
  Branches                        3911     3933      +22     
=============================================================
+ Hits                           11592    11634      +42     
- Misses                          1279     1292      +13     
- Partials                         379      385       +6     

Flag	Coverage Δ
unittest	87.40% <69.35%> (-0.09%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ges/eslint-plugin/src/util/getStaticStringValue.ts	23.52% <23.52%> (ø)
.../eslint-plugin/src/rules/class-methods-use-this.ts	86.36% <86.36%> (ø)
packages/eslint-plugin/src/util/isNullLiteral.ts	100.00% <100.00%> (ø)

[JoshuaKGoldberg]

unrelated?

[bradzacher]

it was just me fleshing out the template
i noticed this was super easy to miss this so I made it more obvious!

[JoshuaKGoldberg]

I like it :)

[JoshuaKGoldberg]

Super! ✨

ACK on the pulling in code from upstream as-is. I trust you on filling in the missing unit tests coverage if needed for the rule.

[JoshuaKGoldberg]

[Testing] Was it intentional that these bits aren't covered by unit tests?

[bradzacher]

I've got all the tests from the base rule - so either it's not covered by the base tests or code cov is wrong again. IDK

[JoshuaKGoldberg]

If ESLint core isn't testing these lines, who are we to dispute??

The base branch was changed.